You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by ajantha-bhat <gi...@git.apache.org> on 2018/08/07 14:52:06 UTC

[GitHub] carbondata pull request #2615: [HOTFIX] [presto] presto code cleanup

GitHub user ajantha-bhat opened a pull request:

    https://github.com/apache/carbondata/pull/2615

    [HOTFIX] [presto] presto code cleanup

    Changes in the PR:
    a. Removed spark jars from release jars dependency
    b. enable check style for presto module
    c. fixed all the checkstyle for presto module
    
    Be sure to do all of the following checklist to help us incorporate 
    your contribution quickly and easily:
    
     - [ ] Any interfaces changed? NA
     
     - [ ] Any backward compatibility impacted? NA
     
     - [ ] Document update required? NA
    
     - [ ] Testing done. NA
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.  NA
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ajantha-bhat/carbondata master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2615.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2615
    
----
commit 399ca66addcd6767bc43ac7fa15514eb705546d4
Author: ajantha-bhat <aj...@...>
Date:   2018-08-06T12:21:03Z

    [HOTFIX] presto code cleanup
    
    a. Removed spark jars from release jars dependency
    b. enable check style for presto module
    c. fixed all the checkstyle for presto module

----


---

[GitHub] carbondata issue #2615: [HOTFIX] [presto] presto code cleanup

Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2615
  
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6202/



---

[GitHub] carbondata issue #2615: [HOTFIX] [presto] presto code cleanup

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2615
  
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6552/



---

[GitHub] carbondata pull request #2615: [HOTFIX] [presto] presto integration code cle...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2615


---

[GitHub] carbondata issue #2615: [HOTFIX] [presto] presto code cleanup

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2615
  
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7828/



---

[GitHub] carbondata issue #2615: [HOTFIX] [presto] presto integration code cleanup

Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on the issue:

    https://github.com/apache/carbondata/pull/2615
  
    LGTM


---

[GitHub] carbondata issue #2615: [HOTFIX] [presto] presto integration code cleanup

Posted by ajantha-bhat <gi...@git.apache.org>.
Github user ajantha-bhat commented on the issue:

    https://github.com/apache/carbondata/pull/2615
  
    @bhavya411 : please review


---

[GitHub] carbondata issue #2615: [HOTFIX] [presto] presto integration code cleanup

Posted by ajantha-bhat <gi...@git.apache.org>.
Github user ajantha-bhat commented on the issue:

    https://github.com/apache/carbondata/pull/2615
  
    @chenliang613 : please review. 


---