You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/07 10:26:34 UTC

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #38132: [SPARK-40677][CONNECT][BUILD] Shade more dependency to be able to run separately

HyukjinKwon commented on code in PR #38132:
URL: https://github.com/apache/spark/pull/38132#discussion_r989938384


##########
connector/connect/pom.xml:
##########
@@ -271,6 +282,31 @@
               <pattern>io.grpc</pattern>
               <shadedPattern>${spark.shade.packageName}.connect.grpc</shadedPattern>
             </relocation>
+
+            <relocation>
+              <pattern>com.google.android</pattern>

Review Comment:
   Hey sure, please go ahead with a followup. I just rushed to merge to fix up the broken tests with Maven :-).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org