You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by SpyderRiverA <gi...@git.apache.org> on 2015/04/29 21:28:56 UTC

[GitHub] spark pull request: [SPARK][MLLIB] Added computeInverse to RowMatr...

GitHub user SpyderRiverA opened a pull request:

    https://github.com/apache/spark/pull/5785

    [SPARK][MLLIB] Added computeInverse to RowMatrix.scala

    Added computeInverse to RowMatrix.scala

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/SpyderRiverA/spark master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/5785.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5785
    
----
commit 301b9d9f78ba64f00f11bb8bf9ce325a7898e699
Author: SpyderRiverA <sp...@users.noreply.github.com>
Date:   2014-06-09T16:52:43Z

    Merge pull request #1 from apache/master
    
    updating my fork

commit a0e22a7655c94348c927a26f245cb0cc9a697fdb
Author: SpyderRiverA <sp...@users.noreply.github.com>
Date:   2014-08-19T20:03:39Z

    Merge pull request #2 from apache/master
    
    update fork

commit 1f07f9ca04bb3d7936b9d56cc5a63db5f038b2bd
Author: SpyderRiverA <sp...@users.noreply.github.com>
Date:   2014-08-24T12:50:16Z

    Merge pull request #3 from apache/master
    
    update fork

commit f352df398fb59e52854a18e489db7ba4e8ab5786
Author: SpyderRiverA <sp...@users.noreply.github.com>
Date:   2014-10-04T01:44:00Z

    Merge pull request #4 from apache/master
    
    updating fork

commit 4981d6492dc449bb3b675e813c69309954bd2776
Author: Stephanie Rickett <ri...@bah.com>
Date:   2015-04-13T17:57:07Z

    Merge remote-tracking branch 'upstream/master'

commit e00e9adfa92579dfe4d9944a96d63edb08df04cf
Author: Stephanie Rickett <ri...@bah.com>
Date:   2015-04-29T19:25:21Z

    added computeInverse

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-7250][MLLIB] Added computeInverse to Ro...

Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5785#discussion_r29385039
  
    --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/RowMatrix.scala ---
    @@ -315,6 +315,30 @@ class RowMatrix(
       }
     
       /**
    +    * Computes the inverse matrix using SVD
    +    * @return a DenseMatrix
    +    */
    +  def computeInverse(): DenseMatrix = {
    +  val nCoef = X.numCols.toInt
    --- End diff --
    
    The indentation and whitespace is off throughout this function, and I think one line won't pass style checks for its length. This is minor though.
    
    The bigger concern I have is, where do we need an inverse versus solving a system? and the SVD is not always the best way to do it, etc. That is I don't know how much we go down this road of trying to expose another whole library for matrix ops.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-7250][MLLIB] Added computeInverse to Ro...

Posted by SpyderRivera <gi...@git.apache.org>.
Github user SpyderRivera closed the pull request at:

    https://github.com/apache/spark/pull/5785


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-7250][MLLIB] Added computeInverse to Ro...

Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:

    https://github.com/apache/spark/pull/5785#issuecomment-97805567
  
    @SpyderRivera I wasn't saying that this definitely shouldn't be added, just opening the question. Maybe @mengxr can weigh in or @jkbradley


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #5785: [SPARK-7250][MLLIB] Added computeInverse to RowMatrix.sca...

Posted by kingsaction <gi...@git.apache.org>.
Github user kingsaction commented on the issue:

    https://github.com/apache/spark/pull/5785
  
    @srowen how to add funciton that inverse matrix ?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK][MLLIB] Added computeInverse to RowMatr...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/5785#issuecomment-97553247
  
    Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org