You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Istvan Toth (Jira)" <ji...@apache.org> on 2024/12/10 11:57:00 UTC

[jira] [Resolved] (HBASE-29016) Refactor assembly creation to use only DependencySets and move cached classpath creation to a new module

     [ https://issues.apache.org/jira/browse/HBASE-29016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Istvan Toth resolved HBASE-29016.
---------------------------------
    Fix Version/s: 3.0.0-beta-2
       Resolution: Fixed

Committed to master and branch-3.

Thanks for the review [~nihaljain.cs] and [~zhangduo] .

> Refactor assembly creation to use only DependencySets and move cached classpath creation to a new module
> --------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-29016
>                 URL: https://issues.apache.org/jira/browse/HBASE-29016
>             Project: HBase
>          Issue Type: Improvement
>          Components: build
>            Reporter: Istvan Toth
>            Assignee: Istvan Toth
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 3.0.0-beta-2
>
>
> There are a few problem with the current assembly creation:
> * The assembly and cached classpath creation is done from the same module, even though they need to include different JARs.
> *  To filter out the test jars, the descriptor uses a combination of moduleSets and dependencySets.
> * However, the results are less than ideal, as some test-related JARs are still included in the assembly, while some others have multiple versions of the same jar added to the assembly.
> Separating the assembly and cached classpath creation lets us build the assembly without the extra test dependencies and duplicate versions in a much simpler and more robust manner.
> Relying heavily on the maven dependency mechanism solves the problem of duplicate versions, and not depending on the test-related modules at all solves the problem of lingering test dependencies.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)