[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #5653: Enhance min/max value support in realtime segment creation

[GitBox <gi...@apache.org>]

mcvsubbu commented on a change in pull request #5653:
URL: https://github.com/apache/incubator-pinot/pull/5653#discussion_r449710829



##########
File path: pinot-core/src/main/java/org/apache/pinot/core/indexsegment/mutable/MutableSegmentImpl.java
##########
@@ -514,6 +522,30 @@ private void addForwardIndex(GenericRow row, int docId, Map<String, Object> dict
 
         numValuesInfo.updateMVEntry(dictIds.length);
       }
+
+      // Update min/max value for columns
+      BaseMutableDictionary dictionary = _dictionaryMap.get(column);
+      if (dictionary != null) {
+        _minValueMap.put(column, dictionary.getMinVal());

Review comment:
       In case of offheap string dictionary it will create a new string everytime from the serialized values. Why nnot just get the minvalue when needed from the dictionary?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org