You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/08/24 12:56:48 UTC
[GitHub] [hudi] Trevor-zhang opened a new pull request #2021: [HUDI-1218]Introduce BulkInsertSortMode as Independent class
Trevor-zhang opened a new pull request #2021:
URL: https://github.com/apache/hudi/pull/2021
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contributing.html before opening a pull request.*
## What is the purpose of the pull request
*Introduce BulkInsertSortMode as Independent class*
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yanghua commented on a change in pull request #2021: [HUDI-1218]Introduce BulkInsertSortMode as Independent class
Posted by GitBox <gi...@apache.org>.
yanghua commented on a change in pull request #2021:
URL: https://github.com/apache/hudi/pull/2021#discussion_r476098066
##########
File path: hudi-client/src/main/java/org/apache/hudi/execution/bulkinsert/BulkInsertInternalPartitionerFactory.java
##########
@@ -39,10 +39,4 @@ public static BulkInsertPartitioner get(BulkInsertSortMode sortMode) {
throw new HoodieException("The bulk insert mode \"" + sortMode.name() + "\" is not supported.");
Review comment:
`The bulk insert sort mode `? better?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yanghua merged pull request #2021: [HUDI-1218] Introduce BulkInsertSortMode as Independent class
Posted by GitBox <gi...@apache.org>.
yanghua merged pull request #2021:
URL: https://github.com/apache/hudi/pull/2021
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] Trevor-zhang commented on pull request #2021: [HUDI-1218]Introduce BulkInsertSortMode as Independent class
Posted by GitBox <gi...@apache.org>.
Trevor-zhang commented on pull request #2021:
URL: https://github.com/apache/hudi/pull/2021#issuecomment-679110335
hi,@yanghua，can u take a look when freeeeeeeee ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] Trevor-zhang commented on a change in pull request #2021: [HUDI-1218] Introduce BulkInsertSortMode as Independent class
Posted by GitBox <gi...@apache.org>.
Trevor-zhang commented on a change in pull request #2021:
URL: https://github.com/apache/hudi/pull/2021#discussion_r476102080
##########
File path: hudi-client/src/main/java/org/apache/hudi/execution/bulkinsert/BulkInsertInternalPartitionerFactory.java
##########
@@ -39,10 +39,4 @@ public static BulkInsertPartitioner get(BulkInsertSortMode sortMode) {
throw new HoodieException("The bulk insert mode \"" + sortMode.name() + "\" is not supported.");
Review comment:
> `The bulk insert sort mode `? better?
I think so. i have changed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org