You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2020/02/19 08:50:56 UTC

[GitHub] [tinkerpop] dzmitry-lahoda commented on issue #1247: TINKERPOP-2192 Null checks added to Connection.Parse

dzmitry-lahoda commented on issue #1247: TINKERPOP-2192 Null checks added to Connection.Parse
URL: https://github.com/apache/tinkerpop/pull/1247#issuecomment-588105418
 
 
   Change looks pretty safe. Event check for `null` in message is kind of reasonable, because  could return null https://github.com/JamesNK/Newtonsoft.Json/blob/a31156e90a14038872f54eb60ff0e9676ca4a0d8/Src/Newtonsoft.Json/JsonConvert.cs#L823 . Also at same time not sure if it hides bad JSON setting or other json related behind.  Should we fail totally in this case?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services