[GitHub] [shardingsphere] azexcy commented on a diff in pull request #24146: Using streaming query at pipeline inventory dump and data consistency check

["azexcy (via GitHub)" <gi...@apache.org>]

azexcy commented on code in PR #24146:
URL: https://github.com/apache/shardingsphere/pull/24146#discussion_r1105238188


##########
jdbc/core/src/main/java/org/apache/shardingsphere/driver/data/pipeline/datasource/creator/ShardingSpherePipelineDataSourceCreator.java:
##########
@@ -41,6 +42,8 @@ public DataSource createPipelineDataSource(final Object dataSourceConfig) throws
         enableRangeQueryForInline(shardingRuleConfig);
         rootConfig.setDatabaseName(null);
         rootConfig.setSchemaName(null);
+        // TODO set a large enough value, make sure when a jdbc streaming query parameter is take effect
+        rootConfig.getProps().put(ConfigurationPropertyKey.MAX_CONNECTIONS_SIZE_PER_QUERY.getKey(), 100000);

Review Comment:
   When the number of database connections is less than the number of slices, there will be problems



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org