You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2023/01/04 09:52:59 UTC
[GitHub] [iceberg] Fokko opened a new pull request, #6521: Python: Add Docker suggestion for testing
Fokko opened a new pull request, #6521:
URL: https://github.com/apache/iceberg/pull/6521
Running the tests in Docker makes sure that the tests aren't affected by the host system:
I had to remove a couple of tests since they don't work inside Docker. This is because by default you're root in docker, and chmod'ing certain directories doesn't work, because you can still read them as root.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko commented on a diff in pull request #6521: Python: Add Docker suggestion for testing
Posted by GitBox <gi...@apache.org>.
Fokko commented on code in PR #6521:
URL: https://github.com/apache/iceberg/pull/6521#discussion_r1063500822
##########
python/tests/io/test_pyarrow.py:
##########
@@ -195,62 +195,6 @@ def test_raise_on_opening_a_local_file_not_found() -> None:
assert "[Errno 2] Failed to open local file" in str(exc_info.value)
-def test_raise_on_opening_a_local_file_no_permission() -> None:
Review Comment:
I removed these tests since they don't work inside of a plain docker container because, in a docker container, everything runs under root unless specified otherwise. I don't feel like creating a special Docker image for this. These tests just assert the `PermissionError` that comes from Python itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #6521: Python: Add Docker suggestion for testing
Posted by GitBox <gi...@apache.org>.
rdblue merged PR #6521:
URL: https://github.com/apache/iceberg/pull/6521
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org