You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/01 08:26:47 UTC
[GitHub] [airflow] zhongjiajie opened a new pull request #6987:
[AIRFLOW-6416] Remove DB provide_session and sort by conn_id
zhongjiajie opened a new pull request #6987: [AIRFLOW-6416] Remove DB provide_session and sort by conn_id
URL: https://github.com/apache/airflow/pull/6987
* Remove unnecessary annotation provide_session
* Sort create_default_connections by connection id
* Add sort connection id unittest
- [x] Description above provides context of the change
- [x] Commit message contains [\[AIRFLOW-XXXX\]](https://issues.apache.org/jira/browse/AIRFLOW-6416) or `[AIRFLOW-6416]` for document-only changes
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [ ] Relevant documentation is updated including usage instructions.
- [ ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] zhongjiajie edited a comment on issue #6987:
[AIRFLOW-6416] Remove DB provide_session and sort by conn_id
Posted by GitBox <gi...@apache.org>.
zhongjiajie edited a comment on issue #6987: [AIRFLOW-6416] Remove DB provide_session and sort by conn_id
URL: https://github.com/apache/airflow/pull/6987#issuecomment-570040683
> @zhongjiajie why do you want to remove @provide_session ? The way it works now, it will create a new session for each connection - each merge_conn will have a new session (which basically means new connection established with the database). With @provide_sesion, the session will be reused whereas with the new approach it will be create/commit/close for every single Connection entry.
I think we don't need to create connect in function `create_default_connections`, because it will be create in function `merge_conn`, so I remove it. but when you comment in
> We should not remove @provide_session as it is there to make all the connections reuse session rather than recreate sessions.
I get that point
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on issue #6987: [AIRFLOW-6416] Sort
default connection by conn_id
Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #6987: [AIRFLOW-6416] Sort default connection by conn_id
URL: https://github.com/apache/airflow/pull/6987#issuecomment-570057169
Do we need this? The connections in the Airflow UI are already sorted.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] zhongjiajie commented on issue #6987: [AIRFLOW-6416]
Remove DB provide_session and sort by conn_id
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on issue #6987: [AIRFLOW-6416] Remove DB provide_session and sort by conn_id
URL: https://github.com/apache/airflow/pull/6987#issuecomment-570040683
> @zhongjiajie why do you want to remove @provide_session ? The way it works now, it will create a new session for each connection - each merge_conn will have a new session (which basically means new connection established with the database). With @provide_sesion, the session will be reused whereas with the new approach it will be create/commit/close for every single Connection entry.
I think we do not need connect in create default connection, because it will be create in function `merge_conn`, so I remove it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6987:
[AIRFLOW-6416] Sort default connection by conn_id
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6987: [AIRFLOW-6416] Sort default connection by conn_id
URL: https://github.com/apache/airflow/pull/6987#issuecomment-570035935
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6987?src=pr&el=h1) Report
> Merging [#6987](https://codecov.io/gh/apache/airflow/pull/6987?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/baaf7ee435886b1bb5cce703da40b375ba2b8c50?src=pr&el=desc) will **decrease** coverage by `0.28%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/6987?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6987 +/- ##
==========================================
- Coverage 84.84% 84.56% -0.29%
==========================================
Files 679 679
Lines 38536 38536
==========================================
- Hits 32697 32588 -109
- Misses 5839 5948 +109
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6987?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/utils/db.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kYi5weQ==) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.88% <0%> (+0.28%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6987?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6987?src=pr&el=footer). Last update [baaf7ee...4154a3e](https://codecov.io/gh/apache/airflow/pull/6987?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6987:
[AIRFLOW-6416] Remove DB provide_session and sort by conn_id
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6987: [AIRFLOW-6416] Remove DB provide_session and sort by conn_id
URL: https://github.com/apache/airflow/pull/6987#issuecomment-570035935
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6987?src=pr&el=h1) Report
> Merging [#6987](https://codecov.io/gh/apache/airflow/pull/6987?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6d2b4b721f823310b52fb2ea20fd3d23261a109d?src=pr&el=desc) will **decrease** coverage by `0.28%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/6987?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6987 +/- ##
==========================================
- Coverage 84.85% 84.56% -0.29%
==========================================
Files 679 679
Lines 38536 38535 -1
==========================================
- Hits 32698 32586 -112
- Misses 5838 5949 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6987?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/utils/db.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kYi5weQ==) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/operators/postgres\_operator.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvcG9zdGdyZXNfb3BlcmF0b3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/operators/mysql\_operator.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvbXlzcWxfb3BlcmF0b3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/operators/mysql\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvbXlzcWxfdG9faGl2ZS5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/operators/generic\_transfer.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvZ2VuZXJpY190cmFuc2Zlci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `88.43% <0%> (ø)` | :arrow_up: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| ... and [10 more](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6987?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6987?src=pr&el=footer). Last update [6d2b4b7...21cb5dc](https://codecov.io/gh/apache/airflow/pull/6987?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] zhongjiajie commented on issue #6987: [AIRFLOW-6416] Sort
default connection by conn_id
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on issue #6987: [AIRFLOW-6416] Sort default connection by conn_id
URL: https://github.com/apache/airflow/pull/6987#issuecomment-570977908
Thanks Jarek and Kaxil for review
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6987:
[AIRFLOW-6416] Sort default connection by conn_id
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6987: [AIRFLOW-6416] Sort default connection by conn_id
URL: https://github.com/apache/airflow/pull/6987#issuecomment-570035935
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6987?src=pr&el=h1) Report
> Merging [#6987](https://codecov.io/gh/apache/airflow/pull/6987?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/baaf7ee435886b1bb5cce703da40b375ba2b8c50?src=pr&el=desc) will **decrease** coverage by `0.28%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/6987?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6987 +/- ##
==========================================
- Coverage 84.84% 84.56% -0.29%
==========================================
Files 679 679
Lines 38536 38536
==========================================
- Hits 32697 32588 -109
- Misses 5839 5948 +109
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6987?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/utils/db.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kYi5weQ==) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.88% <0%> (+0.28%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6987?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6987?src=pr&el=footer). Last update [baaf7ee...4154a3e](https://codecov.io/gh/apache/airflow/pull/6987?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] zhongjiajie commented on issue #6987: [AIRFLOW-6416]
Remove DB provide_session and sort by conn_id
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on issue #6987: [AIRFLOW-6416] Remove DB provide_session and sort by conn_id
URL: https://github.com/apache/airflow/pull/6987#issuecomment-570033848
Oh, we already add more probot to repo, Mergeable is good!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #6987: [AIRFLOW-6416] Remove DB
provide_session and sort by conn_id
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #6987: [AIRFLOW-6416] Remove DB provide_session and sort by conn_id
URL: https://github.com/apache/airflow/pull/6987#issuecomment-570036826
@zhongjiajie why do you want to remove @provide_session ? The way it works now, it will create a new session for each connection - each merge_conn will have a new session (which basically means new connection established with the database). With @provide_sesion, the session will be reused whereas with the new approach it will be create/commit/close for every single Connection entry.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk merged pull request #6987: [AIRFLOW-6416] Sort
default connection by conn_id
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #6987: [AIRFLOW-6416] Sort default connection by conn_id
URL: https://github.com/apache/airflow/pull/6987
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] zhongjiajie commented on issue #6987: [AIRFLOW-6416] Sort
default connection by conn_id
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on issue #6987: [AIRFLOW-6416] Sort default connection by conn_id
URL: https://github.com/apache/airflow/pull/6987#issuecomment-570928265
So what should I do in this situation ? close this PR or do some else? @potiuk @kaxil
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6987:
[AIRFLOW-6416] Remove DB provide_session and sort by conn_id
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6987: [AIRFLOW-6416] Remove DB provide_session and sort by conn_id
URL: https://github.com/apache/airflow/pull/6987#issuecomment-570035935
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6987?src=pr&el=h1) Report
> Merging [#6987](https://codecov.io/gh/apache/airflow/pull/6987?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6d2b4b721f823310b52fb2ea20fd3d23261a109d?src=pr&el=desc) will **decrease** coverage by `0.28%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/6987?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6987 +/- ##
==========================================
- Coverage 84.85% 84.56% -0.29%
==========================================
Files 679 679
Lines 38536 38535 -1
==========================================
- Hits 32698 32586 -112
- Misses 5838 5949 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6987?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/utils/db.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kYi5weQ==) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/operators/postgres\_operator.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvcG9zdGdyZXNfb3BlcmF0b3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/operators/mysql\_operator.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvbXlzcWxfb3BlcmF0b3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/operators/mysql\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvbXlzcWxfdG9faGl2ZS5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/operators/generic\_transfer.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvZ2VuZXJpY190cmFuc2Zlci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `88.43% <0%> (ø)` | :arrow_up: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| ... and [10 more](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6987?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6987?src=pr&el=footer). Last update [6d2b4b7...21cb5dc](https://codecov.io/gh/apache/airflow/pull/6987?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6987:
[AIRFLOW-6416] Sort default connection by conn_id
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6987: [AIRFLOW-6416] Sort default connection by conn_id
URL: https://github.com/apache/airflow/pull/6987#issuecomment-570035935
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6987?src=pr&el=h1) Report
> Merging [#6987](https://codecov.io/gh/apache/airflow/pull/6987?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/869ca9619c6af8103b1b6af4e1d2f0cf82d89e6f?src=pr&el=desc) will **decrease** coverage by `0.28%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/6987?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6987 +/- ##
=========================================
- Coverage 84.99% 84.7% -0.29%
=========================================
Files 679 679
Lines 38647 38647
=========================================
- Hits 32847 32737 -110
- Misses 5800 5910 +110
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6987?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/utils/db.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kYi5weQ==) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6987?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6987?src=pr&el=footer). Last update [869ca96...ccaa6d8](https://codecov.io/gh/apache/airflow/pull/6987?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] zhongjiajie commented on issue #6987: [AIRFLOW-6416] Sort
default connection by conn_id
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on issue #6987: [AIRFLOW-6416] Sort default connection by conn_id
URL: https://github.com/apache/airflow/pull/6987#issuecomment-570064562
I think it will more easy to maintain the code, what do you think? @kaxil
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #6987: [AIRFLOW-6416] Remove DB
provide_session and sort by conn_id
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #6987: [AIRFLOW-6416] Remove DB provide_session and sort by conn_id
URL: https://github.com/apache/airflow/pull/6987#issuecomment-570042926
> And we could not remove @provide_session in function `merge_conn` due to some unittest use it to create temp connections, do we? @potiuk
The @provide_session decorator (and merge_conn uses it) follow exactly the pattern of optimisation - it's there to handle the case that a session is created once, transaction starts, and you reuse the session do everything in the same transatction. So it is really needed :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #6987: [AIRFLOW-6416]
Remove DB provide_session and sort by conn_id
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #6987: [AIRFLOW-6416] Remove DB provide_session and sort by conn_id
URL: https://github.com/apache/airflow/pull/6987#issuecomment-570035935
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6987?src=pr&el=h1) Report
> Merging [#6987](https://codecov.io/gh/apache/airflow/pull/6987?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6d2b4b721f823310b52fb2ea20fd3d23261a109d?src=pr&el=desc) will **decrease** coverage by `0.86%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/6987?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6987 +/- ##
==========================================
- Coverage 84.85% 83.98% -0.87%
==========================================
Files 679 679
Lines 38536 38535 -1
==========================================
- Hits 32698 32363 -335
- Misses 5838 6172 +334
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6987?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/utils/db.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kYi5weQ==) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/operators/postgres\_operator.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvcG9zdGdyZXNfb3BlcmF0b3IucHk=) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/operators/mysql\_operator.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvbXlzcWxfb3BlcmF0b3IucHk=) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/operators/mysql\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvbXlzcWxfdG9faGl2ZS5weQ==) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/operators/generic\_transfer.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvZ2VuZXJpY190cmFuc2Zlci5weQ==) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `49.65% <0%> (-38.78%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| ... and [10 more](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6987?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6987?src=pr&el=footer). Last update [6d2b4b7...21cb5dc](https://codecov.io/gh/apache/airflow/pull/6987?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk edited a comment on issue #6987: [AIRFLOW-6416]
Remove DB provide_session and sort by conn_id
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on issue #6987: [AIRFLOW-6416] Remove DB provide_session and sort by conn_id
URL: https://github.com/apache/airflow/pull/6987#issuecomment-570042926
> And we could not remove @provide_session in function `merge_conn` due to some unittest use it to create temp connections, do we? @potiuk
The @provide_session decorator (and merge_conn uses it) follow exactly the pattern of session/transaction passing. It's there to handle the case that a session is created once, transaction starts, and you reuse the session do everything in the same DB transaction. So it is really needed :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6987:
[AIRFLOW-6416] Sort default connection by conn_id
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6987: [AIRFLOW-6416] Sort default connection by conn_id
URL: https://github.com/apache/airflow/pull/6987#issuecomment-570035935
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6987?src=pr&el=h1) Report
> Merging [#6987](https://codecov.io/gh/apache/airflow/pull/6987?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/baaf7ee435886b1bb5cce703da40b375ba2b8c50?src=pr&el=desc) will **decrease** coverage by `0.28%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/6987?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6987 +/- ##
==========================================
- Coverage 84.84% 84.56% -0.29%
==========================================
Files 679 679
Lines 38536 38536
==========================================
- Hits 32697 32588 -109
- Misses 5839 5948 +109
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6987?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/utils/db.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kYi5weQ==) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.88% <0%> (+0.28%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6987?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6987?src=pr&el=footer). Last update [baaf7ee...4154a3e](https://codecov.io/gh/apache/airflow/pull/6987?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] zhongjiajie commented on issue #6987: [AIRFLOW-6416]
Remove DB provide_session and sort by conn_id
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on issue #6987: [AIRFLOW-6416] Remove DB provide_session and sort by conn_id
URL: https://github.com/apache/airflow/pull/6987#issuecomment-570040438
And we could not remove @provide_session in function `merge_conn` due to some unittest use it to create temp connections, do we? @potiuk
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6987:
[AIRFLOW-6416] Remove DB provide_session and sort by conn_id
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6987: [AIRFLOW-6416] Remove DB provide_session and sort by conn_id
URL: https://github.com/apache/airflow/pull/6987#issuecomment-570035935
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6987?src=pr&el=h1) Report
> Merging [#6987](https://codecov.io/gh/apache/airflow/pull/6987?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6d2b4b721f823310b52fb2ea20fd3d23261a109d?src=pr&el=desc) will **decrease** coverage by `0.86%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/6987?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6987 +/- ##
==========================================
- Coverage 84.85% 83.98% -0.87%
==========================================
Files 679 679
Lines 38536 38535 -1
==========================================
- Hits 32698 32363 -335
- Misses 5838 6172 +334
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6987?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/utils/db.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kYi5weQ==) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/operators/postgres\_operator.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvcG9zdGdyZXNfb3BlcmF0b3IucHk=) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/operators/mysql\_operator.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvbXlzcWxfb3BlcmF0b3IucHk=) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/operators/mysql\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvbXlzcWxfdG9faGl2ZS5weQ==) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/operators/generic\_transfer.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvZ2VuZXJpY190cmFuc2Zlci5weQ==) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `49.65% <0%> (-38.78%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| ... and [10 more](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6987?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6987?src=pr&el=footer). Last update [6d2b4b7...21cb5dc](https://codecov.io/gh/apache/airflow/pull/6987?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6987:
[AIRFLOW-6416] Sort default connection by conn_id
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6987: [AIRFLOW-6416] Sort default connection by conn_id
URL: https://github.com/apache/airflow/pull/6987#issuecomment-570035935
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6987?src=pr&el=h1) Report
> Merging [#6987](https://codecov.io/gh/apache/airflow/pull/6987?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/baaf7ee435886b1bb5cce703da40b375ba2b8c50?src=pr&el=desc) will **decrease** coverage by `0.28%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/6987?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6987 +/- ##
==========================================
- Coverage 84.84% 84.56% -0.29%
==========================================
Files 679 679
Lines 38536 38536
==========================================
- Hits 32697 32588 -109
- Misses 5839 5948 +109
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6987?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/utils/db.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kYi5weQ==) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.88% <0%> (+0.28%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6987?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6987?src=pr&el=footer). Last update [baaf7ee...4154a3e](https://codecov.io/gh/apache/airflow/pull/6987?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #6987: [AIRFLOW-6416] Sort
default connection by conn_id
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #6987: [AIRFLOW-6416] Sort default connection by conn_id
URL: https://github.com/apache/airflow/pull/6987#issuecomment-570093941
No strong opinion - but I think it only makes sense if we enforce it afterwards (like we did with a number of other pre-commit checks). It's low priority I think.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] zhongjiajie edited a comment on issue #6987:
[AIRFLOW-6416] Sort default connection by conn_id
Posted by GitBox <gi...@apache.org>.
zhongjiajie edited a comment on issue #6987: [AIRFLOW-6416] Sort default connection by conn_id
URL: https://github.com/apache/airflow/pull/6987#issuecomment-570064562
I think it maybe more easy to maintain the code, what do you think? @kaxil
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6987:
[AIRFLOW-6416] Sort default connection by conn_id
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6987: [AIRFLOW-6416] Sort default connection by conn_id
URL: https://github.com/apache/airflow/pull/6987#issuecomment-570035935
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6987?src=pr&el=h1) Report
> Merging [#6987](https://codecov.io/gh/apache/airflow/pull/6987?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6d2b4b721f823310b52fb2ea20fd3d23261a109d?src=pr&el=desc) will **decrease** coverage by `0.28%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/6987?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6987 +/- ##
==========================================
- Coverage 84.85% 84.56% -0.29%
==========================================
Files 679 679
Lines 38536 38536
==========================================
- Hits 32698 32588 -110
- Misses 5838 5948 +110
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6987?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/utils/db.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kYi5weQ==) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6987/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6987?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6987?src=pr&el=footer). Last update [6d2b4b7...4154a3e](https://codecov.io/gh/apache/airflow/pull/6987?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on issue #6987: [AIRFLOW-6416] Sort
default connection by conn_id
Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #6987: [AIRFLOW-6416] Sort default connection by conn_id
URL: https://github.com/apache/airflow/pull/6987#issuecomment-570091803
> I think it maybe more easy to maintain the code, what do you think? @kaxil
I don't have a strong opinion against it as you might be right it might be good to have it in alphabetical order. WDYT @potiuk ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services