You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/06/26 11:10:06 UTC
[GitHub] [airflow] potiuk opened a new pull request #16674: Add preparatio of images as part of RC preparation process
potiuk opened a new pull request #16674:
URL: https://github.com/apache/airflow/pull/16674
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #16674: Add preparation of images as part of RC preparation process
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #16674:
URL: https://github.com/apache/airflow/pull/16674#discussion_r659726275
##########
File path: scripts/ci/libraries/_build_images.sh
##########
@@ -743,8 +743,8 @@ function build_images::prepare_prod_build() {
build_images::add_build_args_for_remote_install
elif [[ -n "${INSTALL_AIRFLOW_VERSION=}" ]]; then
# When --install-airflow-version is used then the image is build using released PIP package
- # For PROD image only numeric versions are allowed
- if [[ ! ${INSTALL_AIRFLOW_VERSION} =~ ^[0-9\.]*$ ]]; then
+ # For PROD image only numeric versions are allowed and RC candidates
+ if [[ ! ${INSTALL_AIRFLOW_VERSION} =~ ^[0-9\.]*(rc[0-9]*)?$ ]]; then
Review comment:
Ah indeed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #16674: Add preparation of images as part of RC preparation process
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #16674:
URL: https://github.com/apache/airflow/pull/16674#issuecomment-869627030
> Can he ask or would we (PMC) have to ask on his behalf?
I asked as a committer and they gave me access, so I guess should be possible :). But I am happy to create a ticket there if I know the username on DockerHub.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #16674: Add preparation of images as part of RC preparation process
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #16674:
URL: https://github.com/apache/airflow/pull/16674#discussion_r659726820
##########
File path: tests/jobs/test_scheduler_job.py
##########
@@ -3650,7 +3650,7 @@ def test_task_with_upstream_skip_process_task_instances():
assert dr is not None
with create_session() as session:
- tis = {ti.task_id: ti for ti in dr.get_task_instances(session=session)}
+ tis = {ti.task_id: ti for ti in dr.get_task_instances(session=session)} # pylint: disable=no-member
Review comment:
True :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #16674: Add preparation of images as part of RC preparation process
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #16674:
URL: https://github.com/apache/airflow/pull/16674#discussion_r659729725
##########
File path: tests/jobs/test_scheduler_job.py
##########
@@ -3660,7 +3660,7 @@ def test_task_with_upstream_skip_process_task_instances():
# dag_file_processor._process_task_instances(dag, dag_runs=dag_runs)
with create_session() as session:
- tis = {ti.task_id: ti for ti in dr.get_task_instances(session=session)}
+ tis = {ti.task_id: ti for ti in dr.get_task_instances(session=session)} # pylint: disable=no-member
Review comment:
```suggestion
tis = {ti.task_id: ti for ti in dr.get_task_instances(session=session)}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #16674: Add preparation of images as part of RC preparation process
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #16674:
URL: https://github.com/apache/airflow/pull/16674#discussion_r659724552
##########
File path: scripts/ci/libraries/_build_images.sh
##########
@@ -743,8 +743,8 @@ function build_images::prepare_prod_build() {
build_images::add_build_args_for_remote_install
elif [[ -n "${INSTALL_AIRFLOW_VERSION=}" ]]; then
# When --install-airflow-version is used then the image is build using released PIP package
- # For PROD image only numeric versions are allowed
- if [[ ! ${INSTALL_AIRFLOW_VERSION} =~ ^[0-9\.]*$ ]]; then
+ # For PROD image only numeric versions are allowed and RC candidates
+ if [[ ! ${INSTALL_AIRFLOW_VERSION} =~ ^[0-9\.]*(rc[0-9]*)?$ ]]; then
Review comment:
```suggestion
if [[ ! ${INSTALL_AIRFLOW_VERSION} =~ ^[0-9\.]+(rc[0-9]+)?$ ]]; then
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #16674: Add preparation of images as part of RC preparation process
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16674:
URL: https://github.com/apache/airflow/pull/16674#issuecomment-869631722
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #16674: Add preparation of images as part of RC preparation process
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #16674:
URL: https://github.com/apache/airflow/pull/16674#issuecomment-869624475
Can he ask or would we (PMC) have to ask on his behalf?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #16674: Add preparation of images as part of RC preparation process
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #16674:
URL: https://github.com/apache/airflow/pull/16674
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #16674: Add preparation of images as part of RC preparation process
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #16674:
URL: https://github.com/apache/airflow/pull/16674#discussion_r659726557
##########
File path: tests/jobs/test_scheduler_job.py
##########
@@ -3650,7 +3650,7 @@ def test_task_with_upstream_skip_process_task_instances():
assert dr is not None
with create_session() as session:
- tis = {ti.task_id: ti for ti in dr.get_task_instances(session=session)}
+ tis = {ti.task_id: ti for ti in dr.get_task_instances(session=session)} # pylint: disable=no-member
Review comment:
```suggestion
tis = {ti.task_id: ti for ti in dr.get_task_instances(session=session)}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #16674: Add preparation of images as part of RC preparation process
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #16674:
URL: https://github.com/apache/airflow/pull/16674#discussion_r659724744
##########
File path: scripts/ci/libraries/_build_images.sh
##########
@@ -743,8 +743,8 @@ function build_images::prepare_prod_build() {
build_images::add_build_args_for_remote_install
elif [[ -n "${INSTALL_AIRFLOW_VERSION=}" ]]; then
# When --install-airflow-version is used then the image is build using released PIP package
- # For PROD image only numeric versions are allowed
- if [[ ! ${INSTALL_AIRFLOW_VERSION} =~ ^[0-9\.]*$ ]]; then
+ # For PROD image only numeric versions are allowed and RC candidates
+ if [[ ! ${INSTALL_AIRFLOW_VERSION} =~ ^[0-9\.]*(rc[0-9]*)?$ ]]; then
Review comment:
(Assuming bash regex work this way)
##########
File path: tests/jobs/test_scheduler_job.py
##########
@@ -3650,7 +3650,7 @@ def test_task_with_upstream_skip_process_task_instances():
assert dr is not None
with create_session() as session:
- tis = {ti.task_id: ti for ti in dr.get_task_instances(session=session)}
+ tis = {ti.task_id: ti for ti in dr.get_task_instances(session=session)} # pylint: disable=no-member
Review comment:
Not needed now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #16674: Add preparation of images as part of RC preparation process
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #16674:
URL: https://github.com/apache/airflow/pull/16674#issuecomment-869217946
Looks like all good. Would be handy for the final release of 2.1.1 :). The nice thing is that we can use master scripts + Docker to build the image from the released version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #16674: Add preparation of images as part of RC preparation process
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #16674:
URL: https://github.com/apache/airflow/pull/16674#issuecomment-868986044
I enabled preparing RC images as part of the release process. I think it might be useful for people to run some tests for RCs more easily - especially if they use docker-compose or helm chart.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #16674: Add preparation of images as part of RC preparation process
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #16674:
URL: https://github.com/apache/airflow/pull/16674#issuecomment-868987123
@jhtimmins - you will have to ask (via INFRA Jira ticket) so that you are added to "airflow admins" group for in DockerHub - to be able to push images there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #16674: Add preparation of images as part of RC preparation process
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #16674:
URL: https://github.com/apache/airflow/pull/16674
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org