[GitHub] [incubator-devlake] mindlesscloud commented on a diff in pull request #2557: fix: running gitextractor as a standalone process

[GitBox <gi...@apache.org>]

mindlesscloud commented on code in PR #2557:
URL: https://github.com/apache/incubator-devlake/pull/2557#discussion_r926227497


##########
plugins/gitextractor/main.go:
##########
@@ -74,7 +74,7 @@ func main() {
 		"git extractor",
 		nil,
 	)
-	repo, err := newGitRepo(subTaskCtx.TaskContext(), storage, tasks.GitExtractorOptions{

Review Comment:
   My intention was to reduce the dependencies on `subtaskCtx` to a minimum. It's hard to write a unit test, due to the complicate of `subtaskCtx`. So I removed all the `subtaskCtx` from all functions/methods parameters except the real subtasks `CollectTags`, `CollectCommits`, and `CollectBranches`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org