variableRowHeight style

[Greg Brown <gk...@mac.com>]

Code review for the variableRowHeight change to TerraTableViewSkin. Overall, looks good. Comments below.


Line 83: Rename to rowHeights and change to ArrayList.

Line 184: Insert spaces around equals operator.

Line 294: No need to pass the column sequence to this method. You can just get a reference to it within the method itself.

Line 334: Insert a CR after the closing curly brace.

Line 380: Unnecessary line feed.

Line 516: Is this the correct Javadoc for this method?

Line 536: We should probably only pass -1 as the width constraint if the column width is -1. Otherwise, we should pass the value from the columnWidths array, so the renderer can properly constrain itself. We should probably add a columnWidths argument to the method, since we can't rely on the member variable reflecting the proper state when this method is called.

I am guessing that this is at least part of the reason you were not seeing the behavior you expected when using a TextArea as a renderer.