You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@calcite.apache.org by "Marieke Gueye (Jira)" <ji...@apache.org> on 2023/04/20 04:21:00 UTC
[jira] [Created] (CALCITE-5663) [TestKit] RelOptFixture does not enforce the collation
Marieke Gueye created CALCITE-5663:
--------------------------------------
Summary: [TestKit] RelOptFixture does not enforce the collation
Key: CALCITE-5663
URL: https://issues.apache.org/jira/browse/CALCITE-5663
Project: Calcite
Issue Type: Bug
Reporter: Marieke Gueye
In RelOptFixture, we currently change the traitsets to enforce EnumerableConvention.INSTANCE, however, in this instance we forget to port the collation in the traitset.
```
if (planner instanceof VolcanoPlanner) {
r2 =
planner.changeTraits(relBefore,
relBefore.getTraitSet().replace(EnumerableConvention.INSTANCE));
} else {
r2 = relBefore;
}
```
The problem goes even deeper, as of now, there is no way to get access to the collation as it lives in the relRoot, and we currently only access the relNode through the `relSupplier`
The consequence of this can be pretty dire as it may mean that some rules might be incorrectly tested.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)