You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "Andy Wick (JIRA)" <ji...@apache.org> on 2011/05/16 21:17:47 UTC

[jira] [Created] (AVRO-821) PHP protocol support

PHP protocol support
--------------------

                 Key: AVRO-821
                 URL: https://issues.apache.org/jira/browse/AVRO-821
             Project: Avro
          Issue Type: New Feature
          Components: php
    Affects Versions: 1.5.1
         Environment: all
            Reporter: Andy Wick


PHP version doesn't support protocol format

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (AVRO-821) PHP protocol support

Posted by "A B (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AVRO-821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140620#comment-13140620 ] 

A B commented on AVRO-821:
--------------------------

I created a basic test for this patch by copying/porting the test from Python - will be posting a patch shortly as well. Will this be adequate to get this change checked in please?

                
> PHP protocol support
> --------------------
>
>                 Key: AVRO-821
>                 URL: https://issues.apache.org/jira/browse/AVRO-821
>             Project: Avro
>          Issue Type: New Feature
>          Components: php
>    Affects Versions: 1.5.1
>         Environment: all
>            Reporter: Andy Wick
>             Fix For: 1.5.1
>
>         Attachments: AVRO-821-fixed.patch, avro.patch
>
>
> PHP version doesn't support protocol format

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (AVRO-821) PHP protocol support

Posted by "Doug Cutting (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AVRO-821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Doug Cutting updated AVRO-821:
------------------------------

       Resolution: Fixed
    Fix Version/s:     (was: 1.5.1)
                   1.6.1
         Assignee: A B
     Hadoop Flags: Reviewed
           Status: Resolved  (was: Patch Available)

I committed this.  Thanks to all who contributed!
                
> PHP protocol support
> --------------------
>
>                 Key: AVRO-821
>                 URL: https://issues.apache.org/jira/browse/AVRO-821
>             Project: Avro
>          Issue Type: New Feature
>          Components: php
>    Affects Versions: 1.5.1
>         Environment: all
>            Reporter: Andy Wick
>            Assignee: A B
>             Fix For: 1.6.1
>
>         Attachments: AVRO-821-fixed.patch, avro-821-test.patch, avro.patch
>
>
> PHP version doesn't support protocol format

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (AVRO-821) PHP protocol support

Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AVRO-821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13108137#comment-13108137 ] 

Doug Cutting commented on AVRO-821:
-----------------------------------

This parses protocols, but doesn't appear to be able to make RPC calls using a protocol.  Is that right?

Should we commit this as a step towards a complete PHP RPC implementation?  If so, it would be nice to see some tests added with this code before we do.

> PHP protocol support
> --------------------
>
>                 Key: AVRO-821
>                 URL: https://issues.apache.org/jira/browse/AVRO-821
>             Project: Avro
>          Issue Type: New Feature
>          Components: php
>    Affects Versions: 1.5.1
>         Environment: all
>            Reporter: Andy Wick
>             Fix For: 1.5.1
>
>         Attachments: AVRO-821-fixed.patch, avro.patch
>
>
> PHP version doesn't support protocol format

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (AVRO-821) PHP protocol support

Posted by "Saleem Shafi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AVRO-821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Saleem Shafi updated AVRO-821:
------------------------------

    Attachment: AVRO-821-fixed.patch

We had a few problems with the original patch, so here's an updated one that worked for us.

> PHP protocol support
> --------------------
>
>                 Key: AVRO-821
>                 URL: https://issues.apache.org/jira/browse/AVRO-821
>             Project: Avro
>          Issue Type: New Feature
>          Components: php
>    Affects Versions: 1.5.1
>         Environment: all
>            Reporter: Andy Wick
>             Fix For: 1.5.1
>
>         Attachments: AVRO-821-fixed.patch, avro.patch
>
>
> PHP version doesn't support protocol format

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (AVRO-821) PHP protocol support

Posted by "Andy Wick (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AVRO-821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andy Wick updated AVRO-821:
---------------------------

    Attachment: avro.patch

My attempt of adding protocol support to the php code

> PHP protocol support
> --------------------
>
>                 Key: AVRO-821
>                 URL: https://issues.apache.org/jira/browse/AVRO-821
>             Project: Avro
>          Issue Type: New Feature
>          Components: php
>    Affects Versions: 1.5.1
>         Environment: all
>            Reporter: Andy Wick
>             Fix For: 1.5.1
>
>         Attachments: avro.patch
>
>
> PHP version doesn't support protocol format

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (AVRO-821) PHP protocol support

Posted by "A B (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AVRO-821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

A B updated AVRO-821:
---------------------

    Attachment:     (was: avro-821-test.patch)
    
> PHP protocol support
> --------------------
>
>                 Key: AVRO-821
>                 URL: https://issues.apache.org/jira/browse/AVRO-821
>             Project: Avro
>          Issue Type: New Feature
>          Components: php
>    Affects Versions: 1.5.1
>         Environment: all
>            Reporter: Andy Wick
>             Fix For: 1.5.1
>
>         Attachments: AVRO-821-fixed.patch, avro-821-test.patch, avro.patch
>
>
> PHP version doesn't support protocol format

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (AVRO-821) PHP protocol support

Posted by "A B (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AVRO-821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

A B updated AVRO-821:
---------------------

    Attachment: avro-821-test.patch

Patch to include new unit test for testing protocol support - mostly a verbatim port of the test as it resides in the Python tree.
                
> PHP protocol support
> --------------------
>
>                 Key: AVRO-821
>                 URL: https://issues.apache.org/jira/browse/AVRO-821
>             Project: Avro
>          Issue Type: New Feature
>          Components: php
>    Affects Versions: 1.5.1
>         Environment: all
>            Reporter: Andy Wick
>             Fix For: 1.5.1
>
>         Attachments: AVRO-821-fixed.patch, avro-821-test.patch, avro.patch
>
>
> PHP version doesn't support protocol format

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (AVRO-821) PHP protocol support

Posted by "Doug Cutting (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AVRO-821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140641#comment-13140641 ] 

Doug Cutting commented on AVRO-821:
-----------------------------------

A test would be great!  Thanks!
                
> PHP protocol support
> --------------------
>
>                 Key: AVRO-821
>                 URL: https://issues.apache.org/jira/browse/AVRO-821
>             Project: Avro
>          Issue Type: New Feature
>          Components: php
>    Affects Versions: 1.5.1
>         Environment: all
>            Reporter: Andy Wick
>             Fix For: 1.5.1
>
>         Attachments: AVRO-821-fixed.patch, avro.patch
>
>
> PHP version doesn't support protocol format

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (AVRO-821) PHP protocol support

Posted by "A B (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AVRO-821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

A B updated AVRO-821:
---------------------

    Attachment: avro-821-test.patch

Mostly-verbatim port of protocol test as found in the Python tree.
                
> PHP protocol support
> --------------------
>
>                 Key: AVRO-821
>                 URL: https://issues.apache.org/jira/browse/AVRO-821
>             Project: Avro
>          Issue Type: New Feature
>          Components: php
>    Affects Versions: 1.5.1
>         Environment: all
>            Reporter: Andy Wick
>             Fix For: 1.5.1
>
>         Attachments: AVRO-821-fixed.patch, avro-821-test.patch, avro.patch
>
>
> PHP version doesn't support protocol format

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (AVRO-821) PHP protocol support

Posted by "Andy Wick (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AVRO-821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andy Wick updated AVRO-821:
---------------------------

    Fix Version/s: 1.5.1
     Release Note: php protocol support
           Status: Patch Available  (was: Open)

> PHP protocol support
> --------------------
>
>                 Key: AVRO-821
>                 URL: https://issues.apache.org/jira/browse/AVRO-821
>             Project: Avro
>          Issue Type: New Feature
>          Components: php
>    Affects Versions: 1.5.1
>         Environment: all
>            Reporter: Andy Wick
>             Fix For: 1.5.1
>
>
> PHP version doesn't support protocol format

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira