[jira] [Work logged] (KNOX-3148) Make pac4j session cookie SameSite attribute configurable

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/KNOX-3148?focusedWorklogId=968957&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-968957 ]

ASF GitHub Bot logged work on KNOX-3148:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 08/May/25 11:30
            Start Date: 08/May/25 11:30
    Worklog Time Spent: 10m 
      Work Description: hanicz opened a new pull request, #1042:
URL: https://github.com/apache/knox/pull/1042

   ## What changes were proposed in this pull request?
   
   SameSite attribute for the pac4j session cookies are configurable now. The default value is `Strict`.
   The pac4j Cookie class doesn't support the SameSite attribute so I had to change the implementation to Set-Cookie headers.
   Modified MockHttpServletResponse class to accommodate the testing of multiple Set-Cookie headers.
   
   ## How was this patch tested?
   
   Manually tested, unit tests
   ![image](https://github.com/user-attachments/assets/d3dc44e2-9ab4-449e-ae3f-04ec58156754)
   
   




Issue Time Tracking
-------------------

            Worklog Id:     (was: 968957)
    Remaining Estimate: 0h
            Time Spent: 10m

> Make pac4j session cookie SameSite attribute configurable
> ---------------------------------------------------------
>
>                 Key: KNOX-3148
>                 URL: https://issues.apache.org/jira/browse/KNOX-3148
>             Project: Apache Knox
>          Issue Type: Improvement
>          Components: Server
>    Affects Versions: 2.2.0
>            Reporter: Tamás Hanicz
>            Assignee: Tamás Hanicz
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Make pac4j session cookie SameSite attribute configurable. Currently it is set to None.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)