[GitHub] [zeppelin] jongyoul commented on a change in pull request #4239: [ZEPPELIN-5545] Support multiple maven repo in zeppelin.interpreter.d…

[GitBox <gi...@apache.org>]

jongyoul commented on a change in pull request #4239:
URL: https://github.com/apache/zeppelin/pull/4239#discussion_r719878328



##########
File path: zeppelin-interpreter/src/main/java/org/apache/zeppelin/dep/Booter.java
##########
@@ -78,20 +82,32 @@ static String resolveLocalRepoPath(String localRepoPath) {
     return Paths.get(home).resolve(localRepoPath).toAbsolutePath().toString();
   }
 
-  public static RemoteRepository newCentralRepository(Proxy proxy) {
-    String mvnRepo = System.getenv("ZEPPELIN_INTERPRETER_DEP_MVNREPO");
-    if (mvnRepo == null) {
-      mvnRepo = ZeppelinConfiguration.create().getString(
+  public static List<RemoteRepository> newCentralRepository(Proxy proxy) {

Review comment:
       I think we could add a test to check proper input/output. Could you please add it?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org