You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2004/12/16 18:50:08 UTC

[Bug 4034] New: Upgrade from 2.6 to 3.0 fails

http://bugzilla.spamassassin.org/show_bug.cgi?id=4034

           Summary: Upgrade from 2.6 to 3.0 fails
           Product: Spamassassin
           Version: 3.0.1
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Severity: critical
          Priority: P5
         Component: Building & Packaging
        AssignedTo: dev@spamassassin.apache.org
        ReportedBy: chris-barnes@tamu.edu


Running SA 2.6x on Fedora core 1.  SA called fro /etc/procmail
Also running ClamAV .8 called from MailScanner.

Using the instructions on
http://spamassassin.apache.org/downloads.cgi?update=200410222000, where it says:
Packages
    * RPM: SpamAssassin RPMs can be built directly from the tar file.
          o Simply run:
            rpmbuild -tb Mail-SpamAssassin-3.0.1.tar.gz 

Produces an error when trying to run "spamassassin sample-nonspam.txt" of:
 Use of uninitialized value in numeric eq (==) at
/usr/lib/perl5/site_perl/5.8.3/Mail/SpamAssassin/Conf/Parser.pm line 730.
Use of uninitialized value in numeric eq (==) at
/usr/lib/perl5/site_perl/5.8.3/Mail/SpamAssassin/Conf/Parser.pm line 730.
Use of uninitialized value in numeric eq (==) at
/usr/lib/perl5/site_perl/5.8.3/Mail/SpamAssassin/Conf/Parser.pm line 730.
Use of uninitialized value in numeric eq (==) at
/usr/lib/perl5/site_perl/5.8.3/Mail/SpamAssassin/Conf/Parser.pm line 730.
Use of uninitialized value in numeric eq (==) at
/usr/lib/perl5/site_perl/5.8.3/Mail/SpamAssassin/Conf/Parser.pm line 730.
Use of uninitialized value in numeric eq (==) at
/usr/lib/perl5/site_perl/5.8.3/Mail/SpamAssassin/Conf/Parser.pm line 730.
Use of uninitialized value in numeric eq (==) at
/usr/lib/perl5/site_perl/5.8.3/Mail/SpamAssassin/Conf/Parser.pm line 730.
Use of uninitialized value in numeric eq (==) at
/usr/lib/perl5/site_perl/5.8.3/Mail/SpamAssassin/Conf/Parser.pm line 730.
Use of uninitialized value in numeric eq (==) at
/usr/lib/perl5/site_perl/5.8.3/Mail/SpamAssassin/Conf/Parser.pm line 730.
Use of uninitialized value in numeric eq (==) at
/usr/lib/perl5/site_perl/5.8.3/Mail/SpamAssassin/Conf/Parser.pm line 730.
Use of uninitialized value in numeric eq (==) at
/usr/lib/perl5/site_perl/5.8.3/Mail/SpamAssassin/Conf/Parser.pm line 730.
Use of uninitialized value in numeric eq (==) at
/usr/lib/perl5/site_perl/5.8.3/Mail/SpamAssassin/Conf/Parser.pm line 730.
Use of uninitialized value in numeric eq (==) at
/usr/lib/perl5/site_perl/5.8.3/Mail/SpamAssassin/Conf/Parser.pm line 730.
Use of uninitialized value in numeric eq (==) at
/usr/lib/perl5/site_perl/5.8.3/Mail/SpamAssassin/Conf/Parser.pm line 730.
Use of uninitialized value in numeric eq (==) at
/usr/lib/perl5/site_perl/5.8.3/Mail/SpamAssassin/Conf/Parser.pm line 730.
Use of uninitialized value in bitwise and (&) at
/usr/lib/perl5/site_perl/5.8.3/Mail/SpamAssassin/Conf/Parser.pm line 640.
Use of uninitialized value in numeric eq (==) at
/usr/lib/perl5/site_perl/5.8.3/Mail/SpamAssassin/Conf/Parser.pm line 678.
Use of uninitialized value in numeric eq (==) at
/usr/lib/perl5/site_perl/5.8.3/Mail/SpamAssassin/Conf/Parser.pm line 678.
Use of uninitialized value in numeric eq (==) at
/usr/lib/perl5/site_perl/5.8.3/Mail/SpamAssassin/Conf/Parser.pm line 678.
Use of uninitialized value in numeric eq (==) at
/usr/lib/perl5/site_perl/5.8.3/Mail/SpamAssassin/Conf/Parser.pm line 678.
Use of uninitialized value in numeric eq (==) at
/usr/lib/perl5/site_perl/5.8.3/Mail/SpamAssassin/Conf/Parser.pm line 678.
Use of uninitialized value in numeric eq (==) at
/usr/lib/perl5/site_perl/5.8.3/Mail/SpamAssassin/Conf/Parser.pm line 678.
Use of uninitialized value in concatenation (.) or string at
/usr/lib/perl5/site_perl/5.8.3/Mail/SpamAssassin/Conf/Parser.pm line 707.
unknown type  for RCVD_IN_4: 18 at
/usr/lib/perl5/site_perl/5.8.3/Mail/SpamAssassin.pm line 1682.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 4034] Upgrade from 2.6 to 3.0 fails

Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4034





------- Additional Comments From felicity@kluge.net  2004-12-16 10:34 -------
Subject: Re:  New: Upgrade from 2.6 to 3.0 fails

On Thu, Dec 16, 2004 at 09:50:08AM -0800, bugzilla-daemon@bugzilla.spamassassin.org wrote:
> Produces an error when trying to run "spamassassin sample-nonspam.txt" of:
>  Use of uninitialized value in numeric eq (==) at
> /usr/lib/perl5/site_perl/5.8.3/Mail/SpamAssassin/Conf/Parser.pm line 730.

At first glance, it looks like you have a bad configuration.

That said, there are places (in a quick look around) in the parser code
which could definitely show these kinds of issues if rules aren't defined
correctly.  Something like:

rawbody FOO

causes a whole bunch of warnings, identical to the ones you're complaining
about.





------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 4034] Conf parser can throw warnings for invalid rules

Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4034

felicity@kluge.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|critical                    |major
           Priority|P5                          |P3
            Summary|Upgrade from 2.6 to 3.0     |Conf parser can throw
                   |fails                       |warnings for invalid rules
   Target Milestone|Future                      |3.0.3



------- Additional Comments From felicity@kluge.net  2004-12-16 10:39 -------
In a quick look around Conf.pm, the issue seems to be that rules that aren't evals aren't checked for 
syntax errors before calling add_test() which fails horribly if no actual RE is given.  All rule types seem 
affected.  (rawbody, full, meta, header, etc.)

BTW, the reason is split doesn't generate empty values if the split fails:

        $self->{parser}->add_test (split(/\s+/,$value,2), $TYPE_RAWBODY_TESTS);

so if $value is "FOO", only ("FOO") comes out, not ("FOO", undef) ...



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 4034] [review] Conf parser can throw warnings for invalid rules

Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4034





------- Additional Comments From felicity@kluge.net  2004-12-20 18:22 -------
Created an attachment (id=2580)
 --> (http://bugzilla.spamassassin.org/attachment.cgi?id=2580&action=view)
suggested patch

split the value ahead of time, and if there aren't enough, return a
MISSING_REQUIRED_VALUE error status.



------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug 4034] [review] Conf parser can throw warnings for invalid rules

Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4034

felicity@kluge.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dev@spamassassin.apache.org
         AssignedTo|dev@spamassassin.apache.org |felicity@kluge.net
           Severity|major                       |normal
            Summary|Conf parser can throw       |[review] Conf parser can
                   |warnings for invalid rules  |throw warnings for invalid
                   |                            |rules



------- Additional Comments From felicity@kluge.net  2004-12-20 18:20 -------
patch coming in a minute



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
You are on the CC list for the bug, or are watching someone who is.

[Bug 4034] [review] Conf parser can throw warnings for invalid rules

Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4034





------- Additional Comments From jm@jmason.org  2005-01-06 17:59 -------
+1

it'd be nice to just refactor that into Parser::add_test btw, but we can do that
in trunk



------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug 4034] Conf parser can throw warnings for invalid rules

Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4034





------- Additional Comments From chris-barnes@tamu.edu  2004-12-16 11:13 -------
The line that said "At first glance, it looks like you have a bad
configuration." was a good clue.  I renamed my old
/etc/mail/spamassassin/local.cf to .old and copied the new local.cf and used it
'as-is'.  Restarted SA and everything now works.

Perhaps something in the UPDATE file should be included to only re-used old
custom rules only after the install/upgrade?



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.