You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by ag...@apache.org on 2015/03/13 01:11:23 UTC

cordova-plugin-file git commit: Don't log stacktrace for normal exceptions (e.g. file not found)

Repository: cordova-plugin-file
Updated Branches:
  refs/heads/master 80cf1de40 -> 6cb1a2091


Don't log stacktrace for normal exceptions (e.g. file not found)


Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-file/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-file/commit/6cb1a209
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-file/tree/6cb1a209
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-file/diff/6cb1a209

Branch: refs/heads/master
Commit: 6cb1a2091d91c2a6eeaf78c84bb50bc8a92ea2cd
Parents: 80cf1de
Author: Andrew Grieve <ag...@chromium.org>
Authored: Thu Mar 12 20:10:57 2015 -0400
Committer: Andrew Grieve <ag...@chromium.org>
Committed: Thu Mar 12 20:10:57 2015 -0400

----------------------------------------------------------------------
 src/android/FileUtils.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-plugin-file/blob/6cb1a209/src/android/FileUtils.java
----------------------------------------------------------------------
diff --git a/src/android/FileUtils.java b/src/android/FileUtils.java
index 67ebbe1..80d281b 100644
--- a/src/android/FileUtils.java
+++ b/src/android/FileUtils.java
@@ -570,7 +570,6 @@ public class FileUtils extends CordovaPlugin {
                 try {
                     f.run();
                 } catch ( Exception e) {
-                    e.printStackTrace();
                     if( e instanceof EncodingException){
                         callbackContext.error(FileUtils.ENCODING_ERR);
                     } else if(e instanceof FileNotFoundException) {
@@ -590,6 +589,7 @@ public class FileUtils extends CordovaPlugin {
                     } else if(e instanceof TypeMismatchException ) {
                         callbackContext.error(FileUtils.TYPE_MISMATCH_ERR);
                     } else {
+                        e.printStackTrace();
                     	callbackContext.error(FileUtils.UNKNOWN_ERR);
                     }
                 }


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org