You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by jv...@apache.org on 2007/01/11 04:39:23 UTC
svn commit: r495101 -
/maven/components/trunk/maven-embedder/src/main/java/org/apache/maven/embedder/MavenEmbedder.java
Author: jvanzyl
Date: Wed Jan 10 19:39:22 2007
New Revision: 495101
URL: http://svn.apache.org/viewvc?view=rev&rev=495101
Log:
o add method so that the artifact handler can be looked up, useful in IDEs where we want to look up whether a particular artifact should be added to the classpath.
Modified:
maven/components/trunk/maven-embedder/src/main/java/org/apache/maven/embedder/MavenEmbedder.java
Modified: maven/components/trunk/maven-embedder/src/main/java/org/apache/maven/embedder/MavenEmbedder.java
URL: http://svn.apache.org/viewvc/maven/components/trunk/maven-embedder/src/main/java/org/apache/maven/embedder/MavenEmbedder.java?view=diff&rev=495101&r1=495100&r2=495101
==============================================================================
--- maven/components/trunk/maven-embedder/src/main/java/org/apache/maven/embedder/MavenEmbedder.java (original)
+++ maven/components/trunk/maven-embedder/src/main/java/org/apache/maven/embedder/MavenEmbedder.java Wed Jan 10 19:39:22 2007
@@ -20,6 +20,8 @@
import org.apache.maven.MavenTools;
import org.apache.maven.SettingsConfigurationException;
import org.apache.maven.artifact.Artifact;
+import org.apache.maven.artifact.handler.ArtifactHandler;
+import org.apache.maven.artifact.handler.manager.ArtifactHandlerManager;
import org.apache.maven.artifact.factory.ArtifactFactory;
import org.apache.maven.artifact.repository.ArtifactRepository;
import org.apache.maven.artifact.repository.ArtifactRepositoryFactory;
@@ -95,6 +97,8 @@
private ArtifactRepositoryLayout defaultArtifactRepositoryLayout;
+ private ArtifactHandlerManager artifactHandlerManager;
+
private Maven maven;
private MavenTools mavenTools;
@@ -296,6 +300,11 @@
artifactResolver.resolve( artifact, remoteRepositories, localRepository );
}
+ public ArtifactHandler getArtifactHandler( Artifact artifact )
+ {
+ return artifactHandlerManager.getArtifactHandler( artifact.getType() );
+ }
+
// ----------------------------------------------------------------------
// Plugins
// ----------------------------------------------------------------------
@@ -465,6 +474,8 @@
defaultsPopulator = (MavenExecutionRequestDefaultsPopulator) container.lookup(
MavenExecutionRequestDefaultsPopulator.ROLE );
+
+ artifactHandlerManager = (ArtifactHandlerManager) container.lookup( ArtifactHandlerManager.ROLE );
// These three things can be cached for a single session of the embedder
settings = mavenTools.buildSettings( req.getUserSettingsFile(), req.getGlobalSettingsFile(), false );
Re: svn commit: r495101 - /maven/components/trunk/maven-embedder/src/main/java/org/apache/maven/embedder/MavenEmbedder.java
Posted by Jason van Zyl <ja...@maven.org>.
On 10 Jan 07, at 10:41 PM 10 Jan 07, Brett Porter wrote:
> If the artifact was created with an artifact factory, isn't there
> already a getHandler() method on the artifact itself?
>
In what there is currently yes, but I'm not going to using it because
the artifact is data and should not carry with with components like
ArtifactHandlers and Repositories. Makes trying to serialize them or
index them very difficult. So I'm not making any of the IDE folks use
them, and ultimately I don't want to even expose that much: this is a
stop gap so Eugene can merge some Eclipse notions of classpaths with
what we provide.
> On 11/01/2007, at 2:39 PM, jvanzyl@apache.org wrote:
>
>> Author: jvanzyl
>> Date: Wed Jan 10 19:39:22 2007
>> New Revision: 495101
>>
>> URL: http://svn.apache.org/viewvc?view=rev&rev=495101
>> Log:
>> o add method so that the artifact handler can be looked up, useful
>> in IDEs where we want to look up whether a particular artifact
>> should be added to the classpath.
>>
>> Modified:
>> maven/components/trunk/maven-embedder/src/main/java/org/apache/
>> maven/embedder/MavenEmbedder.java
>>
>> Modified: maven/components/trunk/maven-embedder/src/main/java/org/
>> apache/maven/embedder/MavenEmbedder.java
>> URL: http://svn.apache.org/viewvc/maven/components/trunk/maven-
>> embedder/src/main/java/org/apache/maven/embedder/
>> MavenEmbedder.java?view=diff&rev=495101&r1=495100&r2=495101
>> =====================================================================
>> =========
>> --- maven/components/trunk/maven-embedder/src/main/java/org/apache/
>> maven/embedder/MavenEmbedder.java (original)
>> +++ maven/components/trunk/maven-embedder/src/main/java/org/apache/
>> maven/embedder/MavenEmbedder.java Wed Jan 10 19:39:22 2007
>> @@ -20,6 +20,8 @@
>> import org.apache.maven.MavenTools;
>> import org.apache.maven.SettingsConfigurationException;
>> import org.apache.maven.artifact.Artifact;
>> +import org.apache.maven.artifact.handler.ArtifactHandler;
>> +import
>> org.apache.maven.artifact.handler.manager.ArtifactHandlerManager;
>> import org.apache.maven.artifact.factory.ArtifactFactory;
>> import org.apache.maven.artifact.repository.ArtifactRepository;
>> import
>> org.apache.maven.artifact.repository.ArtifactRepositoryFactory;
>> @@ -95,6 +97,8 @@
>>
>> private ArtifactRepositoryLayout
>> defaultArtifactRepositoryLayout;
>>
>> + private ArtifactHandlerManager artifactHandlerManager;
>> +
>> private Maven maven;
>>
>> private MavenTools mavenTools;
>> @@ -296,6 +300,11 @@
>> artifactResolver.resolve( artifact, remoteRepositories,
>> localRepository );
>> }
>>
>> + public ArtifactHandler getArtifactHandler( Artifact artifact )
>> + {
>> + return artifactHandlerManager.getArtifactHandler
>> ( artifact.getType() );
>> + }
>> +
>> //
>> ---------------------------------------------------------------------
>> -
>> // Plugins
>> //
>> ---------------------------------------------------------------------
>> -
>> @@ -465,6 +474,8 @@
>>
>> defaultsPopulator =
>> (MavenExecutionRequestDefaultsPopulator) container.lookup(
>> MavenExecutionRequestDefaultsPopulator.ROLE );
>> +
>> + artifactHandlerManager = (ArtifactHandlerManager)
>> container.lookup( ArtifactHandlerManager.ROLE );
>>
>> // These three things can be cached for a single
>> session of the embedder
>> settings = mavenTools.buildSettings
>> ( req.getUserSettingsFile(), req.getGlobalSettingsFile(), false );
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r495101 - /maven/components/trunk/maven-embedder/src/main/java/org/apache/maven/embedder/MavenEmbedder.java
Posted by Brett Porter <br...@apache.org>.
If the artifact was created with an artifact factory, isn't there
already a getHandler() method on the artifact itself?
On 11/01/2007, at 2:39 PM, jvanzyl@apache.org wrote:
> Author: jvanzyl
> Date: Wed Jan 10 19:39:22 2007
> New Revision: 495101
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=495101
> Log:
> o add method so that the artifact handler can be looked up, useful
> in IDEs where we want to look up whether a particular artifact
> should be added to the classpath.
>
> Modified:
> maven/components/trunk/maven-embedder/src/main/java/org/apache/
> maven/embedder/MavenEmbedder.java
>
> Modified: maven/components/trunk/maven-embedder/src/main/java/org/
> apache/maven/embedder/MavenEmbedder.java
> URL: http://svn.apache.org/viewvc/maven/components/trunk/maven-
> embedder/src/main/java/org/apache/maven/embedder/MavenEmbedder.java?
> view=diff&rev=495101&r1=495100&r2=495101
> ======================================================================
> ========
> --- maven/components/trunk/maven-embedder/src/main/java/org/apache/
> maven/embedder/MavenEmbedder.java (original)
> +++ maven/components/trunk/maven-embedder/src/main/java/org/apache/
> maven/embedder/MavenEmbedder.java Wed Jan 10 19:39:22 2007
> @@ -20,6 +20,8 @@
> import org.apache.maven.MavenTools;
> import org.apache.maven.SettingsConfigurationException;
> import org.apache.maven.artifact.Artifact;
> +import org.apache.maven.artifact.handler.ArtifactHandler;
> +import
> org.apache.maven.artifact.handler.manager.ArtifactHandlerManager;
> import org.apache.maven.artifact.factory.ArtifactFactory;
> import org.apache.maven.artifact.repository.ArtifactRepository;
> import
> org.apache.maven.artifact.repository.ArtifactRepositoryFactory;
> @@ -95,6 +97,8 @@
>
> private ArtifactRepositoryLayout defaultArtifactRepositoryLayout;
>
> + private ArtifactHandlerManager artifactHandlerManager;
> +
> private Maven maven;
>
> private MavenTools mavenTools;
> @@ -296,6 +300,11 @@
> artifactResolver.resolve( artifact, remoteRepositories,
> localRepository );
> }
>
> + public ArtifactHandler getArtifactHandler( Artifact artifact )
> + {
> + return artifactHandlerManager.getArtifactHandler
> ( artifact.getType() );
> + }
> +
> //
> ----------------------------------------------------------------------
> // Plugins
> //
> ----------------------------------------------------------------------
> @@ -465,6 +474,8 @@
>
> defaultsPopulator =
> (MavenExecutionRequestDefaultsPopulator) container.lookup(
> MavenExecutionRequestDefaultsPopulator.ROLE );
> +
> + artifactHandlerManager = (ArtifactHandlerManager)
> container.lookup( ArtifactHandlerManager.ROLE );
>
> // These three things can be cached for a single
> session of the embedder
> settings = mavenTools.buildSettings
> ( req.getUserSettingsFile(), req.getGlobalSettingsFile(), false );
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org