You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/06/11 01:22:55 UTC

[GitHub] [incubator-nuttx-apps] nimish commented on a diff in pull request #1191: Address #1190 -- EXAMPLES_ELF_CXX broken w/o exceptions

nimish commented on code in PR #1191:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1191#discussion_r894958998


##########
examples/elf/tests/helloxx/Makefile:
##########
@@ -110,10 +110,11 @@ $(BIN3): $(OBJS3)
 	$(Q) $(LD) $(LDELFFLAGS) $(LDLIBPATH) -o $@ $(ARCHCRT0OBJ) $^ $(LDLIBS)
 
 # BIN4 is similar to BIN3 except that it uses the streams code from libstdc++
-#
+# Both BIN4 and BIN5 use exceptions
 # NOTE:  libstdc++ is not available for NuttX as of this writing
 #
 ifeq ($(CONFIG_EXAMPLES_ELF_CXX),y)
+ifeq ($(CXX_EXCEPTION),y) 

Review Comment:
   That's weird.
   ```suggestion
   ifeq ($(CONFIG_CXX_EXCEPTION),y)
   ```
   Would actually check...perhaps the tests don't ever enable `CONFIG_EXAMPLES_ELF_CXX` ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org