[jira] [Commented] (HADOOP-15161) s3a: Stream and common statistics missing from metrics

["Steve Loughran (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-15161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16316404#comment-16316404 ] 

Steve Loughran commented on HADOOP-15161:
-----------------------------------------

LGTM.
Could you tweak the test so that the input stream is closed in a try-with-resources block. I know its probably overkill, but it's good to set an example in tests for others to cut and paste

Other than that, good to go. +1 pending the test tuning

> s3a: Stream and common statistics missing from metrics
> ------------------------------------------------------
>
>                 Key: HADOOP-15161
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15161
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 3.1.0
>            Reporter: Sean Mackrory
>            Assignee: Sean Mackrory
>         Attachments: HADOOP-15161.001.patch
>
>
> Input stream statistics aren't being passed through to metrics once merged. Also, the following "common statistics" are not being incremented or tracked by metrics:
> {code}
> OP_APPEND
> OP_CREATE
> OP_CREATE_NON_RECURSIVE
> OP_DELETE
> OP_GET_CONTENT_SUMMARY
> OP_GET_FILE_CHECKSUM
> OP_GET_STATUS
> OP_MODIFY_ACL_ENTRIES
> OP_OPEN
> OP_REMOVE_ACL
> OP_REMOVE_ACL_ENTRIES
> OP_REMOVE_DEFAULT_ACL
> OP_SET_ACL
> OP_SET_OWNER
> OP_SET_PERMISSION
> OP_SET_TIMES
> OP_TRUNCATE
> {code}
> Most of those make sense, but we can easily add OP_CREATE (and it's non-recursive cousin), OP_DELETE, OP_OPEN.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org