You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/08/30 16:18:49 UTC

[GitHub] [cloudstack] DaanHoogland commented on pull request #6685: Return volume UUID in the `listRouters` and `listSystemVms` APIs

DaanHoogland commented on PR #6685:
URL: https://github.com/apache/cloudstack/pull/6685#issuecomment-1231886838

   @JoaoJandre in itself the code looks good but I have a problem with the design; a join dao is supposed to get data from a view and not to manippulate or augment it. This is more in place in the service serving the API command. What made you decide to implement it like this? (in the `..JoinDaoImpl` classes)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org