You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/10/02 17:56:01 UTC

[jira] [Commented] (FLINK-7709) Port CheckpointStatsDetailsHandler to new REST endpoint

    [ https://issues.apache.org/jira/browse/FLINK-7709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16188511#comment-16188511 ] 

ASF GitHub Bot commented on FLINK-7709:
---------------------------------------

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/4763

    [FLINK-7709] Add CheckpointStatisticDetailsHandler for new REST endpoint

    ## What is the purpose of the change
    
    Adds the new `CheckpointStatisticDetailsHandler` for the new REST server endpoint.
    
    Moreover, this PR disables the `FAIL_ON_MISSING_CREATOR_PROPERTIES` property for the `RestMapperUtils.getStrictObjectMapper` because that is something the individuals beans can do on their own (e.g. by checking with `Preconditions.checkNotNull`).
    
    R @zentol because of the changes to the `ObjectMapper` setup.
    
    ## Verifying this change
    
    This change is already covered by existing tests, such as `CheckpointingStatisticsTest`.
    
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink portCheckpointStatsDetailsHandler

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4763.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4763
    
----
commit c09e579b26752f2ae477d60e8fbb6ccdce315df9
Author: Till Rohrmann <tr...@apache.org>
Date:   2017-09-25T13:29:59Z

    [FLINK-7668] Add ExecutionGraphCache for ExecutionGraph based REST handlers
    
    The ExecutionGraphCache replaces the ExecutionGraphHolder. Unlike the latter, the former
    does not expect the AccessExecutionGraph to be the true ExecutionGraph. Instead it assumes
    it to be the ArchivedExecutionGraph. Therefore, it invalidates the cache entries after
    a given time to live period. This will trigger requesting the AccessExecutionGraph again
    and, thus, updating the ExecutionGraph information for the ExecutionGraph based REST
    handlers.
    
    In order to avoid memory leaks, the WebRuntimeMonitor starts now a periodic cleanup task
    which triggers ExecutionGraphCache.cleanup. This methods releases all cache entries which
    have exceeded their time to live. Currently it is set to 20 * refreshInterval of the
    web gui.
    
    This closes #4728.

commit a4f9ef81c02738b40cf0ba375650684b46f5417d
Author: Till Rohrmann <tr...@apache.org>
Date:   2017-09-26T16:39:15Z

    [FLINK-7695] [flip6] Add JobConfigHandler for new RestServerEndpoint
    
    This closes #4737.

commit 4259fcc96c7c72644806941bd0df9f508a2f0bcd
Author: Till Rohrmann <tr...@apache.org>
Date:   2017-09-28T16:35:50Z

    [FLINK-7708] [flip6] Add CheckpointConfigHandler for new REST endpoint
    
    This commit implements the CheckpointConfigHandler which now returns a
    CheckpointConfigInfo object if checkpointing is enabled. In case that
    checkpointing is disabled for a job, it will return a 404 response.

commit 6f1756b541ad76521c7b653f834c1032c623f1e6
Author: Till Rohrmann <tr...@apache.org>
Date:   2017-09-29T13:09:06Z

    [FLINK-7710] [flip6] Add CheckpointStatisticsHandler for the new REST endpoint
    
    This commit also makes the CheckpointStatsHistory object serializable by removing the
    CheckpointStatsHistoryIterable and replacing it with a static ArrayList.

commit bd8109b0af1a90fc32f76e57261a252762d678eb
Author: Till Rohrmann <tr...@apache.org>
Date:   2017-10-02T17:39:38Z

    [FLINK-7709] Add CheckpointStatisticDetailsHandler for new REST endpoint

commit 4d694411e9e4b6c508c258655c9c69cb26ddb6be
Author: Till Rohrmann <tr...@apache.org>
Date:   2017-10-02T17:52:13Z

    Disable failing when not all creator properties are known

----


> Port CheckpointStatsDetailsHandler to new REST endpoint
> -------------------------------------------------------
>
>                 Key: FLINK-7709
>                 URL: https://issues.apache.org/jira/browse/FLINK-7709
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Distributed Coordination, REST, Webfrontend
>            Reporter: Tzu-Li (Gordon) Tai
>            Assignee: Till Rohrmann
>              Labels: flip-6
>             Fix For: 1.4.0
>
>
> Port existing {{CheckpointStatsDetailsHandler}} to new REST endpoint.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)