You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by scop <gi...@git.apache.org> on 2015/07/16 12:25:40 UTC
[GitHub] activemq-artemis pull request: Avoid array copy on STOMP encode
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/84
Avoid array copy on STOMP encode
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scop/activemq-artemis encodecopy
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/84.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #84
----
commit a35873ae2d8a53bc5f37c72302282287dcf80ab8
Author: Ville Skyttä <vi...@iki.fi>
Date: 2015-07-16T10:23:58Z
Avoid array copy on STOMP encode
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Avoid array copy on STOMP encode
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/84#issuecomment-122894617
I have merged this, but beware that I squashed your two commits into just one since they both had the same message.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Avoid array copy on STOMP encode
Posted by scop <gi...@git.apache.org>.
Github user scop commented on the pull request:
https://github.com/apache/activemq-artemis/pull/84#issuecomment-122707754
Added a few similar ones on decode side. Test suite passes for me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Avoid array copy on STOMP encode
Posted by scop <gi...@git.apache.org>.
Github user scop commented on the pull request:
https://github.com/apache/activemq-artemis/pull/84#issuecomment-122907609
Ok, but note that the commit messages were not the same (one was encode, the other decode, and one had "some" in plural):
1) Avoid array copy on STOMP encode
2) Avoid some array copies on STOMP decode
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Avoid array copy on STOMP encode
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/84
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Avoid array copy on STOMP encode
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/84#issuecomment-122908003
Oh... ok.. too late now :) already merged!
But this will be good enough
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---