You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Akira Kitada (Created) (JIRA)" <ji...@apache.org> on 2011/12/04 11:31:40 UTC

[jira] [Created] (ZOOKEEPER-1315) zookeeper_init always reports sessionPasswd=

zookeeper_init always reports sessionPasswd=<hidden>
----------------------------------------------------

                 Key: ZOOKEEPER-1315
                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1315
             Project: ZooKeeper
          Issue Type: Bug
          Components: c client
    Affects Versions: 3.4.0, 3.3.4
            Reporter: Akira Kitada
            Priority: Minor


zookeeper_init always reports sessionPasswd=<hidden> even when it's empty.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (ZOOKEEPER-1315) zookeeper_init always reports sessionPasswd=

Posted by "Akira Kitada (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-1315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Akira Kitada updated ZOOKEEPER-1315:
------------------------------------

    Attachment: ZOOKEEPER-1315.patch
    
> zookeeper_init always reports sessionPasswd=<hidden>
> ----------------------------------------------------
>
>                 Key: ZOOKEEPER-1315
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1315
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.3.4, 3.4.0
>            Reporter: Akira Kitada
>            Priority: Minor
>         Attachments: ZOOKEEPER-1315.patch
>
>
> zookeeper_init always reports sessionPasswd=<hidden> even when it's empty.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (ZOOKEEPER-1315) zookeeper_init always reports sessionPasswd=

Posted by "Akira Kitada (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13162389#comment-13162389 ] 

Akira Kitada commented on ZOOKEEPER-1315:
-----------------------------------------

I didn't add tests because I thought the patch is trivial enough and
writing a test that checks stderr output would be tricky.

To verify the fix, I changed the code manually to print INFO log and
checked if it emits "sessionPasswd=<null>" and "sessionPasswd=<hidden>" according to the condition.
                
> zookeeper_init always reports sessionPasswd=<hidden>
> ----------------------------------------------------
>
>                 Key: ZOOKEEPER-1315
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1315
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.3.4, 3.4.0
>            Reporter: Akira Kitada
>            Priority: Minor
>         Attachments: ZOOKEEPER-1315.patch
>
>
> zookeeper_init always reports sessionPasswd=<hidden> even when it's empty.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (ZOOKEEPER-1315) zookeeper_init always reports sessionPasswd=

Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165624#comment-13165624 ] 

Hadoop QA commented on ZOOKEEPER-1315:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12506034/ZOOKEEPER-1315.patch
  against trunk revision 1208979.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/820//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/820//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/820//console

This message is automatically generated.
                
> zookeeper_init always reports sessionPasswd=<hidden>
> ----------------------------------------------------
>
>                 Key: ZOOKEEPER-1315
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1315
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.3.4, 3.4.0
>            Reporter: Akira Kitada
>            Assignee: Akira Kitada
>            Priority: Minor
>             Fix For: 3.5.0, 3.4.1
>
>         Attachments: ZOOKEEPER-1315.patch
>
>
> zookeeper_init always reports sessionPasswd=<hidden> even when it's empty.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (ZOOKEEPER-1315) zookeeper_init always reports sessionPasswd=

Posted by "Mahadev konar (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-1315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mahadev konar updated ZOOKEEPER-1315:
-------------------------------------

    Fix Version/s: 3.4.1
                   3.5.0
         Assignee: Akira Kitada
    
> zookeeper_init always reports sessionPasswd=<hidden>
> ----------------------------------------------------
>
>                 Key: ZOOKEEPER-1315
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1315
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.3.4, 3.4.0
>            Reporter: Akira Kitada
>            Assignee: Akira Kitada
>            Priority: Minor
>             Fix For: 3.5.0, 3.4.1
>
>         Attachments: ZOOKEEPER-1315.patch
>
>
> zookeeper_init always reports sessionPasswd=<hidden> even when it's empty.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (ZOOKEEPER-1315) zookeeper_init always reports sessionPasswd=

Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165672#comment-13165672 ] 

Hadoop QA commented on ZOOKEEPER-1315:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12506034/ZOOKEEPER-1315.patch
  against trunk revision 1212172.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/823//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/823//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/823//console

This message is automatically generated.
                
> zookeeper_init always reports sessionPasswd=<hidden>
> ----------------------------------------------------
>
>                 Key: ZOOKEEPER-1315
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1315
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.3.4, 3.4.0
>            Reporter: Akira Kitada
>            Assignee: Akira Kitada
>            Priority: Minor
>             Fix For: 3.5.0, 3.4.1
>
>         Attachments: ZOOKEEPER-1315.patch
>
>
> zookeeper_init always reports sessionPasswd=<hidden> even when it's empty.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (ZOOKEEPER-1315) zookeeper_init always reports sessionPasswd=

Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13162350#comment-13162350 ] 

Hadoop QA commented on ZOOKEEPER-1315:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12506034/ZOOKEEPER-1315.patch
  against trunk revision 1208979.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/803//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/803//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/803//console

This message is automatically generated.
                
> zookeeper_init always reports sessionPasswd=<hidden>
> ----------------------------------------------------
>
>                 Key: ZOOKEEPER-1315
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1315
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.3.4, 3.4.0
>            Reporter: Akira Kitada
>            Priority: Minor
>         Attachments: ZOOKEEPER-1315.patch
>
>
> zookeeper_init always reports sessionPasswd=<hidden> even when it's empty.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (ZOOKEEPER-1315) zookeeper_init always reports sessionPasswd=

Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165700#comment-13165700 ] 

Hadoop QA commented on ZOOKEEPER-1315:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12506034/ZOOKEEPER-1315.patch
  against trunk revision 1212172.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/824//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/824//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/824//console

This message is automatically generated.
                
> zookeeper_init always reports sessionPasswd=<hidden>
> ----------------------------------------------------
>
>                 Key: ZOOKEEPER-1315
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1315
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.3.4, 3.4.0
>            Reporter: Akira Kitada
>            Assignee: Akira Kitada
>            Priority: Minor
>             Fix For: 3.5.0, 3.4.1
>
>         Attachments: ZOOKEEPER-1315.patch
>
>
> zookeeper_init always reports sessionPasswd=<hidden> even when it's empty.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (ZOOKEEPER-1315) zookeeper_init always reports sessionPasswd=

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13166069#comment-13166069 ] 

Hudson commented on ZOOKEEPER-1315:
-----------------------------------

Integrated in ZooKeeper-trunk #1389 (See [https://builds.apache.org/job/ZooKeeper-trunk/1389/])
    ZOOKEEPER-1315. zookeeper_init always reports sessionPasswd=<hidden>. (Akira Kitada via mahadev)

mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1212192
Files : 
* /zookeeper/trunk/CHANGES.txt
* /zookeeper/trunk/src/c/src/zookeeper.c

                
> zookeeper_init always reports sessionPasswd=<hidden>
> ----------------------------------------------------
>
>                 Key: ZOOKEEPER-1315
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1315
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.3.4, 3.4.0
>            Reporter: Akira Kitada
>            Assignee: Akira Kitada
>            Priority: Minor
>             Fix For: 3.5.0, 3.4.1
>
>         Attachments: ZOOKEEPER-1315.patch
>
>
> zookeeper_init always reports sessionPasswd=<hidden> even when it's empty.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira