You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/02/13 19:20:23 UTC
[GitHub] justinborromeo edited a comment on issue #7002: [Benchmarking] Call
blackhole#consume() on collections instead of iterating through each element
justinborromeo edited a comment on issue #7002: [Benchmarking] Call blackhole#consume() on collections instead of iterating through each element
URL: https://github.com/apache/incubator-druid/pull/7002#issuecomment-463330769
GroupByBenchmark results for `master` and this branch:
Based on the above stats, it would appear as if there was a slight decrease (~2.3%) in score for the 10 tests randomly selected from the GroupBy benchmark. Tests 1 and 73, with their -7.3% and -5.8% change, seem like outliers. @gianm is this enough to determine whether dead-code elimination is happening?
Benchmark info:
- Run on: MacBook Pro
- Heap Memory: 8 GB
- GC: G1
- Warmup Iterations: 15
- Benchmark Iterations: 30
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org