You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by VK Sameer <sa...@collab.net> on 2005/04/22 17:26:33 UTC
Re: svn commit: r14381 - in trunk: subversion/tests/clients/cmdline
On Thu, 2005-04-21 at 16:24 -0500, lundblad@tigris.org wrote:
> Modified: trunk/subversion/tests/clients/cmdline/davautocheck.sh
> +function trap_cleanup() {
> + [ -e "$HTTPD_PID" ] \
> + && kill $(cat "$HTTPD_PID")
> + exit 1
> +}
...
> -kill $(cat "$HTTPD_PID")
> +[ -e "$HTTPD_PID" ] \
> + && kill $(cat "$HTTPD_PID")
Some redundancy here. Also, by this time, $HTTPD_PID will exist, so no
check is needed, unlike if the trap function is re-used.
Regards
Sameer
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r14381 - in trunk: subversion/tests/clients/cmdline
Posted by "Peter N. Lundblad" <pe...@famlundblad.se>.
On Fri, 22 Apr 2005, VK Sameer wrote:
> On Thu, 2005-04-21 at 16:24 -0500, lundblad@tigris.org wrote:
>
> > Modified: trunk/subversion/tests/clients/cmdline/davautocheck.sh
> > +function trap_cleanup() {
> > + [ -e "$HTTPD_PID" ] \
> > + && kill $(cat "$HTTPD_PID")
> > + exit 1
> > +}
> ...
> > -kill $(cat "$HTTPD_PID")
> > +[ -e "$HTTPD_PID" ] \
> > + && kill $(cat "$HTTPD_PID")
>
> Some redundancy here. Also, by this time, $HTTPD_PID will exist, so no
> check is needed, unlike if the trap function is re-used.
>
I removed this check, Good catch!
If you wonder why I didn't call trap_cleanup at the end as your origial
patch did, that's because it added confusion to avoid duplicating a single
line.
I think davautocheck.sh is perfect now:-) No.
Regards,
//Peter
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org