You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/09/01 14:07:34 UTC

[GitHub] [activemq-artemis] michaelpearce-gain commented on a change in pull request #3635: ARTEMIS-2007 - allow redistribution if there are unmatched messages p…

michaelpearce-gain commented on a change in pull request #3635:
URL: https://github.com/apache/activemq-artemis/pull/3635#discussion_r700249500



##########
File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
##########
@@ -1573,6 +1572,17 @@ public synchronized void cancelRedistributor() throws Exception {
 
    @Override
    public int getConsumerCount() {
+      // we don't want to count the redistributor, it is an internal transient entry in the consumer list
+      if (redistributor != null) {

Review comment:
       With this new code, we are adding still a perf penalty, as now with volatile reads we are going to main memory not cpu cache, this affects not just here, but where redistributor is used in many code places.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org