You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/12/10 23:02:47 UTC

[GitHub] [tvm] jroesch commented on a change in pull request #9693: [Relay] PlanDevices supports 'free' on_device annotations

jroesch commented on a change in pull request #9693:
URL: https://github.com/apache/tvm/pull/9693#discussion_r767034518



##########
File path: include/tvm/target/se_scope.h
##########
@@ -170,7 +170,7 @@ class SEScopeNode : public AttrsNode<SEScopeNode> {
    *
    * kInvalidDeviceType denotes unconstrained.
    */
-  int device_type_int;
+  int /* actually DLDeviceType */ device_type_int;

Review comment:
       Should we make these private in C++?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org