[GitHub] [iotdb] LebronAl commented on pull request #2432: fix the analyse startup check bug when building cluster

[GitBox <gi...@apache.org>]

LebronAl commented on pull request #2432:
URL: https://github.com/apache/iotdb/pull/2432#issuecomment-755070315


   Current logic:
   if one node finds all other nodes's config is consistent, then start server;
   else if this node get some but not all reponse indicating their config are consistent and this node never find that there is a inconsistent node, then try to check in next turn.
   else indicating there must be at lease one node's config is inconsistent  with the cluster, then throw exception and stop server.
   
   In my opinion, I think may be we can start server if quorum nodes return consistent check response, so that we can start cluster even one node will never back after a node hang. Of course,  we must ensure the inconsistent node can't join cluster, maybe we need some manual test to see whether a inconsistent node can join the cluster if we change totalNum from allnode.size() to  allnode.size()/2 + 1.
   
   In this commit, it seems that the startupCheck will perform next turn even it find a inconsistent node, but the cluster will never be establishd
   
    


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org