[GitHub] [superset] rusackas commented on pull request #21143: fix(plugin-chart-handlebars): Fixed issue with Helpers

[GitBox <gi...@apache.org>]

rusackas commented on PR #21143:
URL: https://github.com/apache/superset/pull/21143#issuecomment-1230998876

   I _really, really_ appreciate all the work happening in this PR, but I'm a little nervous about this one... it seems like we're taking on much of the functionality of a whole library in terms of stability/security/maintenance. And not the whole library, including time and currency formatters, for example. 
   
   I don't think the optimization of removing moment is all that pertinent to the project, but the `exports not defined` one might be. I haven't noticed this error on Mac, and I don't have a Windows machine to test. Has there been much investigation into testing/resolving this error, other than the approach herein?
   
   Last and maybe least (if I'm over-thinking this), but this seems to be a copy/paste of the just-handlebars-helpers codebase, not an original implementation and would be subject to the copyright of the original library. It's MIT licensed, so we would need to include the author's copyright, and I'm _not sure_ how including MIT licensed code directly within an Apache-licensed file works. ¯\\\_(ツ)_/¯ 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org