You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2020/01/30 21:31:33 UTC
Re: Review Request 72056: Improved performance of v1 agent operator
API GET_METRICS call.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72056/
-----------------------------------------------------------
(Updated Jan. 30, 2020, 9:31 p.m.)
Review request for mesos, Andrei Sekretenko and Greg Mann.
Changes
-------
- Removed unnecessary mesos:: qualification.
Summary (updated)
-----------------
Improved performance of v1 agent operator API GET_METRICS call.
Bugs: MESOS-10026
https://issues.apache.org/jira/browse/MESOS-10026
Repository: mesos
Description (updated)
-------
This follow the same approach used for the master's GET_METRICS call:
https://github.com/apache/mesos/commit/469f2ebaf65b1642d1eb4a1df81a
https://github.com/apache/mesos/commit/3dda3622f5ed01e8c132dc5ca594
That is, serializing directly to protobuf or json from the in-memory
v0 state.
Diffs (updated)
-----
src/slave/http.cpp 04ad0d816618a1880913857a6f0ff38c4643c488
Diff: https://reviews.apache.org/r/72056/diff/2/
Changes: https://reviews.apache.org/r/72056/diff/1-2/
Testing
-------
make check
Thanks,
Benjamin Mahler
Re: Review Request 72056: Improved performance of v1 agent operator
API GET_METRICS call.
Posted by Andrei Sekretenko <as...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72056/#review219650
-----------------------------------------------------------
src/slave/http.cpp
Lines 1079 (patched)
<https://reviews.apache.org/r/72056/#comment307852>
Hmm... do I understand correctly that code for master's GET_METRICS differs only in the type of the `Response` protobuf?
Did you consider templatizing metrics serialization on `Response` and reusing it for both calls?
- Andrei Sekretenko
On Jan. 30, 2020, 9:31 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72056/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2020, 9:31 p.m.)
>
>
> Review request for mesos, Andrei Sekretenko and Greg Mann.
>
>
> Bugs: MESOS-10026
> https://issues.apache.org/jira/browse/MESOS-10026
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This follow the same approach used for the master's GET_METRICS call:
>
> https://github.com/apache/mesos/commit/469f2ebaf65b1642d1eb4a1df81a
> https://github.com/apache/mesos/commit/3dda3622f5ed01e8c132dc5ca594
>
> That is, serializing directly to protobuf or json from the in-memory
> v0 state.
>
>
> Diffs
> -----
>
> src/slave/http.cpp 04ad0d816618a1880913857a6f0ff38c4643c488
>
>
> Diff: https://reviews.apache.org/r/72056/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>