You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "mingmwang (via GitHub)" <gi...@apache.org> on 2023/04/26 05:59:26 UTC
[GitHub] [arrow-datafusion] mingmwang opened a new pull request, #6122: Remove input schema from PhysicalExpr, move the validation logic to phyiscal expression planner
mingmwang opened a new pull request, #6122:
URL: https://github.com/apache/arrow-datafusion/pull/6122
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #6117.
# Rationale for this change
FollowUp after https://github.com/apache/arrow-datafusion/pull/6114
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #6122: Remove input schema from PhysicalExpr, move the validation logic to physical expression planner
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #6122:
URL: https://github.com/apache/arrow-datafusion/pull/6122#discussion_r1177688659
##########
datafusion/physical-expr/src/expressions/datetime.rs:
##########
@@ -37,45 +37,16 @@ pub struct DateTimeIntervalExpr {
lhs: Arc<dyn PhysicalExpr>,
op: Operator,
rhs: Arc<dyn PhysicalExpr>,
- // TODO: move type checking to the planning phase and not in the physical expr
Review Comment:
🎉
##########
datafusion/physical-expr/src/expressions/in_list.rs:
##########
@@ -172,36 +171,36 @@ where
}
/// Creates a `Box<dyn Set>` for the given list of `IN` expressions and `batch`
-fn make_set(array: &dyn Array) -> Result<Box<dyn Set>> {
+fn make_set(array: &dyn Array) -> Result<Arc<dyn Set>> {
Review Comment:
This is a clever idea -- to avoid cloning the set over and over again 👍
##########
datafusion/physical-expr/src/expressions/mod.rs:
##########
@@ -78,7 +78,7 @@ pub use cast::{
cast, cast_column, cast_with_options, CastExpr, DEFAULT_DATAFUSION_CAST_OPTIONS,
};
pub use column::{col, Column, UnKnownColumn};
-pub use datetime::DateTimeIntervalExpr;
+pub use datetime::{date_time_interval_expr, DateTimeIntervalExpr};
Review Comment:
👍
##########
datafusion/physical-expr/src/utils.rs:
##########
@@ -586,28 +586,7 @@ pub fn reassign_predicate_columns(
column.name(),
index,
))));
- } else if let Some(in_list) = expr_any.downcast_ref::<InListExpr>() {
Review Comment:
🎉
##########
datafusion/physical-expr/src/expressions/datetime.rs:
##########
@@ -220,6 +190,36 @@ impl PartialEq<dyn Any> for DateTimeIntervalExpr {
}
}
+/// create a DateIntervalExpr
+pub fn date_time_interval_expr(
Review Comment:
👍 this also follows the model of the other creation functions in physical expr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #6122: Remove input schema from PhysicalExpr, move the validation logic to physical expression planner
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #6122:
URL: https://github.com/apache/arrow-datafusion/pull/6122
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] mingmwang commented on pull request #6122: Remove input schema from PhysicalExpr, move the validation logic to phyiscal expression planner
Posted by "mingmwang (via GitHub)" <gi...@apache.org>.
mingmwang commented on PR #6122:
URL: https://github.com/apache/arrow-datafusion/pull/6122#issuecomment-1522830116
@crepererum
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org