You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by windpiger <gi...@git.apache.org> on 2017/02/15 07:37:10 UTC

[GitHub] spark pull request #15918: [SPARK-18122][SQL][WIP]Fallback to Kryo for unsup...

Github user windpiger commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15918#discussion_r101216681
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala ---
    @@ -708,6 +715,13 @@ object ScalaReflection extends ScalaReflection {
           s.toAttributes
       }
     
    +  /**
    +   * Returns a catalyst DataType and its nullability for the given Scala Type using reflection.
    +   * If the tpe mismatched in schemaFor function, the default BinaryType returned
    +   */
    +  def schemaForDefaultBinaryType(tpe: `Type`): Schema = scala.util.Try(schemaFor(tpe)).toOption
    --- End diff --
    
    Currently this function just used in ser/deser


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org