You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by GitBox <gi...@apache.org> on 2020/03/05 04:37:01 UTC
[GitHub] [carbondata] Indhumathi27 commented on a change in pull request
#3620: [CARBONDATA-3700] Optimize pruning performance
Indhumathi27 commented on a change in pull request #3620: [CARBONDATA-3700] Optimize pruning performance
URL: https://github.com/apache/carbondata/pull/3620#discussion_r388074374
##########
File path: core/src/main/java/org/apache/carbondata/core/datastore/block/SegmentProperties.java
##########
@@ -147,6 +186,28 @@ private void fillBlockToDimensionOrdinalMapping() {
}
}
+ /**
+ * compare the segmentproperties based on fingerprinter
+ */
+ @Override
+ public boolean equals(Object obj) {
+ if (!(obj instanceof SegmentProperties)) {
+ return false;
+ }
+ SegmentProperties another = (SegmentProperties) obj;
Review comment:
Please change the variable name to `segmentProperties`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services