[jira] [Commented] (ARROW-14458) [R] Use expect_snapshot() to improve tests in dplyr funcs strings

["Dragoș Moldovan-Grünfeld (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARROW-14458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17479248#comment-17479248 ] 

Dragoș Moldovan-Grünfeld commented on ARROW-14458:
--------------------------------------------------

For the functions that surface C++ errors, which might be a bit more weird to handle, we have several options:
* not use {{expect_snapshot()}} for them
* make use of the {{transform}} argument that allows us to scrub text from the output
* wait for cpp11 to support classed errors (https://github.com/r-lib/cpp11/issues/250) 

> [R] Use expect_snapshot() to improve tests in dplyr funcs strings
> -----------------------------------------------------------------
>
>                 Key: ARROW-14458
>                 URL: https://issues.apache.org/jira/browse/ARROW-14458
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: R
>            Reporter: Dragoș Moldovan-Grünfeld
>            Assignee: Dragoș Moldovan-Grünfeld
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 8.0.0
>
>          Time Spent: 8h
>  Remaining Estimate: 0h
>
> This comes from [Romain's suggestion|https://github.com/apache/arrow/pull/11502/files/2a8a139b727acb13019da6176444578ead6bf208#r735351673] to transform the test that rely on capturing a string by using a snapshot test (added in {{testthat}}'s 3rd edition). 
> A test like:
> {code:r}
> expect_error(expression, message)
> {code}
> becomes
> {code:r}
> expect_snapshot({
>   (expect_error(expression))
> })
> {code}
> This is probably a more general improvement we can make to our unit tests (i.e. to make more extensive use of the snapshot functionality), but I thought I'd focus on one test file to begin with.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)