[GitHub] [samza] mynameborat commented on a change in pull request #1219: SAMZA-2373: Container Placement Service (core functionality) for container move and restart

[GitBox <gi...@apache.org>]

mynameborat commented on a change in pull request #1219: SAMZA-2373: Container Placement Service (core functionality) for container move and restart
URL: https://github.com/apache/samza/pull/1219#discussion_r348314021
 
 

 ##########
 File path: samza-core/src/main/java/org/apache/samza/clustermanager/ContainerAllocator.java
 ##########
 @@ -415,20 +407,34 @@ public void stop() {
 
 
   /**
-   * Checks if a request has expired.
+   * Checks if a request has expired. If this request is due to a control action, then expiry timeout can be overridden
+   * otherwise defaults to
 
 Review comment:
   not sure if you need to call out the relation between `request` and the `requestExpiryTimeout`.
   1. It is confusing and overwhelms the documentation.
   2. As far as this method is concerned, it is responsible for determining whether a request has expired or not using the requestExpiryTimeout but is not concerned on how expiry timeout is computed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services