You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by jbertram <gi...@git.apache.org> on 2018/02/23 03:06:06 UTC
[GitHub] activemq-artemis pull request #1893: NO-JIRA make MessageConsumerTest determ...
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1893
NO-JIRA make MessageConsumerTest deterministic
The method testStopConnectionDuringOnMessage in this class was relying
on sleep() calls for critical timing. This test fails sometimes on
fast-tests so I modified it to use a latch and a few waitFor calls to be
more deterministic. It also runs in a third of the time now.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis messageConsumerTest
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1893.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1893
----
commit d18cc6606d7026b9a6355e18231174b78dce7dcb
Author: Justin Bertram <jb...@...>
Date: 2018-02-23T03:03:22Z
NO-JIRA make MessageConsumerTest deterministic
The method testStopConnectionDuringOnMessage in this class was relying
on sleep() calls for critical timing. This test fails sometimes on
fast-tests so I modified it to use a latch and a few waitFor calls to be
more deterministic. It also runs in a third of the time now.
----
---
[GitHub] activemq-artemis pull request #1893: NO-JIRA make MessageConsumerTest determ...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1893#discussion_r170359387
--- Diff: tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/MessageConsumerTest.java ---
@@ -2285,7 +2286,6 @@ public void run() {
}
}
- // This is commented out until http:// jira.jboss.com/jira/browse/JBMESSAGING-983 is complete
@Test
public void testStopConnectionDuringOnMessage() throws Exception {
--- End diff --
This is a very old test... probably there's another similar test on our testsuite already.
Perhaps you could check if there is another test doing this already and close this?
---
[GitHub] activemq-artemis pull request #1893: NO-JIRA make MessageConsumerTest determ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1893
---
[GitHub] activemq-artemis pull request #1893: NO-JIRA make MessageConsumerTest determ...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1893#discussion_r170359441
--- Diff: tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/MessageConsumerTest.java ---
@@ -2285,7 +2286,6 @@ public void run() {
}
}
- // This is commented out until http:// jira.jboss.com/jira/browse/JBMESSAGING-983 is complete
@Test
public void testStopConnectionDuringOnMessage() throws Exception {
--- End diff --
I mean.. delete this.
---