You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@polaris.apache.org by sn...@apache.org on 2026/06/22 16:05:22 UTC
(polaris) branch main updated: Add external Polaris server test manager (#4843)
This is an automated email from the ASF dual-hosted git repository.
snazy pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/polaris.git
The following commit(s) were added to refs/heads/main by this push:
new f7bf16d1be Add external Polaris server test manager (#4843)
f7bf16d1be is described below
commit f7bf16d1bea5e664819ea93a8952425685793a37
Author: Robert Stupp <sn...@snazy.de>
AuthorDate: Mon Jun 22 18:05:17 2026 +0200
Add external Polaris server test manager (#4843)
Adds a `PolarisServerManager` implementation for the polaris-server-test-runner plugin.
---
.../it/ext/ExternalPolarisServerManager.java | 81 ++++++++++++++++
.../it/ext/ExternalPolarisServerManagerTest.java | 102 +++++++++++++++++++++
2 files changed, 183 insertions(+)
diff --git a/integration-tests/src/main/java/org/apache/polaris/service/it/ext/ExternalPolarisServerManager.java b/integration-tests/src/main/java/org/apache/polaris/service/it/ext/ExternalPolarisServerManager.java
new file mode 100644
index 0000000000..276ef797ce
--- /dev/null
+++ b/integration-tests/src/main/java/org/apache/polaris/service/it/ext/ExternalPolarisServerManager.java
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.polaris.service.it.ext;
+
+import java.net.URI;
+import org.apache.polaris.service.it.env.ClientCredentials;
+import org.apache.polaris.service.it.env.ClientPrincipal;
+import org.apache.polaris.service.it.env.Server;
+import org.junit.jupiter.api.extension.ExtensionContext;
+
+/**
+ * {@link PolarisServerManager} implementation for tests whose Polaris server lifecycle is managed
+ * outside JUnit, for example by Gradle.
+ */
+public class ExternalPolarisServerManager implements PolarisServerManager {
+
+ public static final String HTTP_PORT_PROPERTY = "quarkus.http.test-port";
+ public static final String HOST_PROPERTY = "polaris.test.server.host";
+
+ @Override
+ public Server serverForContext(ExtensionContext context) {
+ URI baseUri = URI.create(String.format("http://%s:%d", host(), httpPort()));
+ return new Server() {
+ @Override
+ public URI baseUri() {
+ return baseUri;
+ }
+
+ @Override
+ public ClientPrincipal adminCredentials() {
+ return new ClientPrincipal("root", new ClientCredentials("test-admin", "test-secret"));
+ }
+
+ @Override
+ public void close() {
+ // The external process owner is responsible for server lifecycle.
+ }
+ };
+ }
+
+ private static String host() {
+ String host = System.getProperty(HOST_PROPERTY, "localhost");
+ return host.isBlank() ? "localhost" : host;
+ }
+
+ private static int httpPort() {
+ String port = System.getProperty(HTTP_PORT_PROPERTY);
+ if (port == null || port.isBlank()) {
+ throw new IllegalStateException(
+ String.format("System property '%s' must be set", HTTP_PORT_PROPERTY));
+ }
+ try {
+ int parsed = Integer.parseInt(port);
+ if (parsed <= 0 || parsed > 65535) {
+ throw new IllegalArgumentException("Port out of range: " + parsed);
+ }
+ return parsed;
+ } catch (IllegalArgumentException e) {
+ throw new IllegalStateException(
+ String.format(
+ "System property '%s' must be a valid TCP port: %s", HTTP_PORT_PROPERTY, port),
+ e);
+ }
+ }
+}
diff --git a/integration-tests/src/test/java/org/apache/polaris/service/it/ext/ExternalPolarisServerManagerTest.java b/integration-tests/src/test/java/org/apache/polaris/service/it/ext/ExternalPolarisServerManagerTest.java
new file mode 100644
index 0000000000..a6a05bf5b2
--- /dev/null
+++ b/integration-tests/src/test/java/org/apache/polaris/service/it/ext/ExternalPolarisServerManagerTest.java
@@ -0,0 +1,102 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.polaris.service.it.ext;
+
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThatThrownBy;
+
+import org.apache.polaris.service.it.env.Server;
+import org.junit.jupiter.api.AfterEach;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+
+class ExternalPolarisServerManagerTest {
+
+ private String originalHost;
+ private String originalPort;
+
+ @BeforeEach
+ void captureProperties() {
+ originalHost = System.getProperty(ExternalPolarisServerManager.HOST_PROPERTY);
+ originalPort = System.getProperty(ExternalPolarisServerManager.HTTP_PORT_PROPERTY);
+ }
+
+ @AfterEach
+ void restoreProperties() {
+ restore(ExternalPolarisServerManager.HOST_PROPERTY, originalHost);
+ restore(ExternalPolarisServerManager.HTTP_PORT_PROPERTY, originalPort);
+ }
+
+ @Test
+ void serverForContextUsesConfiguredHttpPort() {
+ System.setProperty(ExternalPolarisServerManager.HTTP_PORT_PROPERTY, "12345");
+
+ Server server = new ExternalPolarisServerManager().serverForContext(null);
+
+ assertThat(server.baseUri()).hasToString("http://localhost:12345");
+ assertThat(server.adminCredentials().principalName()).isEqualTo("root");
+ assertThat(server.adminCredentials().credentials().clientId()).isEqualTo("test-admin");
+ assertThat(server.adminCredentials().credentials().clientSecret()).isEqualTo("test-secret");
+ }
+
+ @Test
+ void serverForContextUsesConfiguredHost() {
+ System.setProperty(ExternalPolarisServerManager.HTTP_PORT_PROPERTY, "12345");
+ System.setProperty(ExternalPolarisServerManager.HOST_PROPERTY, "127.0.0.1");
+
+ Server server = new ExternalPolarisServerManager().serverForContext(null);
+
+ assertThat(server.baseUri()).hasToString("http://127.0.0.1:12345");
+ }
+
+ @Test
+ void serverForContextRejectsMissingHttpPort() {
+ System.clearProperty(ExternalPolarisServerManager.HTTP_PORT_PROPERTY);
+
+ assertThatThrownBy(() -> new ExternalPolarisServerManager().serverForContext(null))
+ .isInstanceOf(IllegalStateException.class)
+ .hasMessageContaining(ExternalPolarisServerManager.HTTP_PORT_PROPERTY);
+ }
+
+ @Test
+ void serverForContextRejectsInvalidHttpPort() {
+ System.setProperty(ExternalPolarisServerManager.HTTP_PORT_PROPERTY, "not-a-port");
+
+ assertThatThrownBy(() -> new ExternalPolarisServerManager().serverForContext(null))
+ .isInstanceOf(IllegalStateException.class)
+ .hasMessageContaining(ExternalPolarisServerManager.HTTP_PORT_PROPERTY);
+ }
+
+ @Test
+ void serverForContextRejectsOutOfRangeHttpPort() {
+ System.setProperty(ExternalPolarisServerManager.HTTP_PORT_PROPERTY, "65536");
+
+ assertThatThrownBy(() -> new ExternalPolarisServerManager().serverForContext(null))
+ .isInstanceOf(IllegalStateException.class)
+ .hasMessageContaining(ExternalPolarisServerManager.HTTP_PORT_PROPERTY);
+ }
+
+ private static void restore(String propertyName, String value) {
+ if (value == null) {
+ System.clearProperty(propertyName);
+ } else {
+ System.setProperty(propertyName, value);
+ }
+ }
+}