You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/04/18 02:59:32 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request, #6093: arch/arm: Remove FAR from common/ and arm*/ folder
xiaoxiang781216 opened a new pull request, #6093:
URL: https://github.com/apache/incubator-nuttx/pull/6093
## Summary
Style change only
## Impact
Minor
## Testing
Pass CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #6093: arch/arm: Remove FAR and CODE from common/ and arm*/ folder
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on PR #6093:
URL: https://github.com/apache/incubator-nuttx/pull/6093#issuecomment-1101188700
> > Maybe we can issue a migration to `https://static.dev.sifive.com/dev-tools/freedom-tools/v2020.12/riscv64-unknown-elf-toolchain-10.2.0-2020.12.8-x86_64-apple-darwin.tar.gz` when certs are getting renewed.
>
> let's upgrade to the new version:)?
The new version link also suffers same certificate expiration now :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6093: arch/arm: Remove FAR and CODE from common/ and arm*/ folder
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #6093:
URL: https://github.com/apache/incubator-nuttx/pull/6093#discussion_r851956103
##########
arch/arm/include/arch.h:
##########
@@ -65,7 +65,7 @@ do { \
"\tmov %0, " PIC_REG_STRING "\n\t" \
: "=r"(picbase) \
); \
- *ppicbase = (FAR void*)picbase; \
+ *ppicbase = (void*)picbase; \
Review Comment:
Done.
##########
arch/arm/src/common/arm_backtrace_thumb.c:
##########
@@ -184,13 +184,13 @@ static bool in_code_region(FAR void *pc)
#ifdef CONFIG_MM_KASAN
__attribute__((no_sanitize_address))
#endif
-static FAR void *backtrace_push_internal(FAR void **psp,
- FAR void **ppc)
+static void *backtrace_push_internal(void **psp,
+ void **ppc)
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6093: arch/arm: Remove FAR and CODE from common/ and arm*/ folder
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #6093:
URL: https://github.com/apache/incubator-nuttx/pull/6093#issuecomment-1101186489
> Maybe we can issue a migration to `https://static.dev.sifive.com/dev-tools/freedom-tools/v2020.12/riscv64-unknown-elf-toolchain-10.2.0-2020.12.8-x86_64-apple-darwin.tar.gz` when certs are getting renewed.
let's upgrade to the new version:)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6093: arch/arm: Remove FAR and CODE from common/ and arm*/ folder
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #6093:
URL: https://github.com/apache/incubator-nuttx/pull/6093#discussion_r851914958
##########
arch/arm/include/arch.h:
##########
@@ -65,7 +65,7 @@ do { \
"\tmov %0, " PIC_REG_STRING "\n\t" \
: "=r"(picbase) \
); \
- *ppicbase = (FAR void*)picbase; \
+ *ppicbase = (void*)picbase; \
Review Comment:
```suggestion
*ppicbase = (void *)picbase; \
```
##########
arch/arm/src/common/arm_backtrace_thumb.c:
##########
@@ -184,13 +184,13 @@ static bool in_code_region(FAR void *pc)
#ifdef CONFIG_MM_KASAN
__attribute__((no_sanitize_address))
#endif
-static FAR void *backtrace_push_internal(FAR void **psp,
- FAR void **ppc)
+static void *backtrace_push_internal(void **psp,
+ void **ppc)
Review Comment:
```suggestion
static void *backtrace_push_internal(void **psp,
void **ppc)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6093: arch/arm: Remove FAR and CODE from common/ and arm*/ folder
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #6093:
URL: https://github.com/apache/incubator-nuttx/pull/6093#issuecomment-1101124403
@pkarashchenko macOS CI always fail to:
" wget --quiet https://static.dev.sifive.com/dev-tools/riscv64-unknown-elf-gcc-8.3.0-2019.08.0-x86_64-apple-darwin.tar.gz"
Let's ignore this error temporarily?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #6093: arch/arm: Remove FAR and CODE from common/ and arm*/ folder
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on PR #6093:
URL: https://github.com/apache/incubator-nuttx/pull/6093#issuecomment-1101185146
@xiaoxiang781216 do you consider we can add `--no-check-certificate` as a workaround to get CI running? Or just wait assuming that SiFive will renew certs soon?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #6093: arch/arm: Remove FAR and CODE from common/ and arm*/ folder
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on PR #6093:
URL: https://github.com/apache/incubator-nuttx/pull/6093#issuecomment-1101183063
Maybe we can issue a migration to `https://static.dev.sifive.com/dev-tools/freedom-tools/v2020.12/riscv64-unknown-elf-toolchain-10.2.0-2020.12.8-x86_64-apple-darwin.tar.gz` when certs are getting renewed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko merged pull request #6093: arch/arm: Remove FAR and CODE from common/ and arm*/ folder
Posted by GitBox <gi...@apache.org>.
pkarashchenko merged PR #6093:
URL: https://github.com/apache/incubator-nuttx/pull/6093
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #6093: arch/arm: Remove FAR and CODE from common/ and arm*/ folder
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on PR #6093:
URL: https://github.com/apache/incubator-nuttx/pull/6093#issuecomment-1101137630
Yeah. `Error code: SEC_ERROR_EXPIRED_CERTIFICATE`. Seems like SiFive have to renew certficates
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6093: arch/arm: Remove FAR and CODE from common/ and arm*/ folder
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #6093:
URL: https://github.com/apache/incubator-nuttx/pull/6093#issuecomment-1101195425
> > > Maybe we can issue a migration to `https://static.dev.sifive.com/dev-tools/freedom-tools/v2020.12/riscv64-unknown-elf-toolchain-10.2.0-2020.12.8-x86_64-apple-darwin.tar.gz` when certs are getting renewed.
> >
> >
> > let's upgrade to the new version:)?
>
> The new version link also suffers same certificate expiration now :)
Ok, I added --no-check-certificate in #6094 to workaround it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org