You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/12/03 01:53:22 UTC

[GitHub] [apisix-dashboard] okaybase commented on a change in pull request #2233: feat: basic support Apache APISIX 2.11

okaybase commented on a change in pull request #2233:
URL: https://github.com/apache/apisix-dashboard/pull/2233#discussion_r761593715



##########
File path: web/src/components/Plugin/locales/en-US.ts
##########
@@ -120,6 +123,8 @@ export default {
   'component.pluginForm.limit-count.count.tooltip': 'The specified number of requests threshold.',
   'component.pluginForm.limit-count.time_window.tooltip':
     'The time window in seconds before the request count is reset.',
+  'component.pluginForm.limit-count.key_type.tooltip':
+    'The key type, support: "var" (single var) and "var_combination" (combine var)',
   'component.pluginForm.limit-count.key.tooltip':
     'The user specified key to limit the count, now accept those as key: "remote_addr"(client\'s IP), "server_addr"(server\'s IP), "X-Forwarded-For/X-Real-IP" in request header, "consumer_name"(consumer\'s username) and "service_id".',

Review comment:
       Now the key is `Input` not `Select`, so we can just keep `The user specified key to limit the count.` for `component.pluginForm.limit-count.key.tooltip`

##########
File path: web/src/components/Plugin/locales/zh-CN.ts
##########
@@ -112,6 +115,8 @@ export default {
   'component.pluginForm.limit-count.count.tooltip': '指定时间窗口内的请求数量阈值。',
   'component.pluginForm.limit-count.time_window.tooltip':
     '时间窗口的大小(以秒为单位),超过这个时间就会重置。',
+  'component.pluginForm.limit-count.key_type.tooltip':
+    '关键字类型,支持:var(单变量)和 var_combination(组合变量)',
   'component.pluginForm.limit-count.key.tooltip':
     '用来做请求计数的有效值。例如,可以使用主机名(或服务器区域)作为关键字,以便限制每个主机名规定时间内的请求次数。我们也可以使用客户端地址作为关键字,这样我们就可以避免单个客户端规定时间内多次的连接我们的服务。当前接受的 key 有:"remote_addr"(客户端 IP 地址), "server_addr"(服务端 IP 地址), 请求头中的"X-Forwarded-For" 或 "X-Real-IP", "consumer_name"(consumer 的 username), "service_id" 。',

Review comment:
       Now the key is `Input` not `Select`, so we can remove `当前接受的 key 有:"remote_addr"(客户端 IP 地址), "server_addr"(服务端 IP 地址), 请求头中的"X-Forwarded-For" 或 "X-Real-IP", "consumer_name"(consumer 的 username), "service_id" 。` for `component.pluginForm.limit-count.key.tooltip`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org