You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/04/07 15:47:02 UTC
[GitHub] [trafficcontrol] rob05c opened a new pull request #4606: Add ORT TO
timeout option
rob05c opened a new pull request #4606: Add ORT TO timeout option
URL: https://github.com/apache/trafficcontrol/pull/4606
Exposes the existing atstccfg Traffic Ops timeout as an ORT option.
Also changes the default timeout back to 30s, to match what ORT has
been forever.
This is actually a forward-port of a feature added to 4.0.x (ORT has changed enough, it couldn't easily be backported, had to be re-written).
I manually tested against a production-like Traffic Ops, default works, setting --to_timeout_ms flag works as expected, setting 1ms times out on the first request, setting 100ms succeeds for small requests and times out on the large DSS.
No tests, changes require TO, and ORT doesn't have an integration test framework yet.
No docs, no documented interface change (ORT flags aren't documented, besides the self-documenting script output)
No changelog, no interface change (4.0.x adds this flag, this PR is just adding it to master to match)
- [x] This PR is not related to any other Issue
## Which Traffic Control components are affected by this PR?
- Traffic Ops ORT
## What is the best way to verify this PR?
Run ORT with the flag --to_timeout_ms, set it small, observe timeouts, set it large, observe success.
## If this is a bug fix, what versions of Traffic Control are affected?
Not a bug fix.
## The following criteria are ALL met by this PR
- [x] This PR includes tests OR I have explained why tests are unnecessary
- [x] This PR includes documentation OR I have explained why documentation is unnecessary
- [x] This PR includes an update to CHANGELOG.md OR such an update is not necessary
- [x] This PR includes any and all required license headers
- [x] This PR ensures that database migration sequence is correct OR this PR does not include a database migration
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details)
## Additional Information
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [trafficcontrol] rawlinp merged pull request #4606: Add ORT TO
timeout option
Posted by GitBox <gi...@apache.org>.
rawlinp merged pull request #4606: Add ORT TO timeout option
URL: https://github.com/apache/trafficcontrol/pull/4606
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services