You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by srdo <gi...@git.apache.org> on 2018/01/03 17:20:53 UTC

[GitHub] storm pull request #2496: STORM-2858 1.x

GitHub user srdo opened a pull request:

    https://github.com/apache/storm/pull/2496

    STORM-2858 1.x

    1.x version of https://github.com/apache/storm/pull/2462
    
    I didn't think we needed this initially since asprintf isn't used in 1.x, but it looks like the build is failing on 1.x after upgrading to the newest Travis image (e.g. https://travis-ci.org/apache/storm/builds/324620269).
    
    This only contains the replacement of make-maven-plugin. Make-maven-plugin fails to run autoreconf on Travis. The error log is
    ```
    [DEBUG] Executing: /bin/sh -l -c cd /home/travis/build/srdo/storm/storm-core/target/native/worker-launcher && autoreconf -i
    [DEBUG] /bin/sh: 14: /opt/jdk_switcher/jdk_switcher.sh: [[: not found
    [DEBUG] /bin/sh: 21: /opt/jdk_switcher/jdk_switcher.sh: [[: not found
    [DEBUG] /bin/sh: 28: /opt/jdk_switcher/jdk_switcher.sh: [[: not found
    [DEBUG] /bin/sh: 35: /opt/jdk_switcher/jdk_switcher.sh: [[: not found
    [DEBUG] /bin/sh: 42: /opt/jdk_switcher/jdk_switcher.sh: [[: not found
    [DEBUG] /bin/sh: 49: /opt/jdk_switcher/jdk_switcher.sh: [[: not found
    [DEBUG] /bin/sh: 56: /opt/jdk_switcher/jdk_switcher.sh: [[: not found
    [DEBUG] /bin/sh: 62: /opt/jdk_switcher/jdk_switcher.sh: [[: not found
    [DEBUG] /bin/sh: 62: /opt/jdk_switcher/jdk_switcher.sh: [[: not found
    [DEBUG] /bin/sh: 62: /opt/jdk_switcher/jdk_switcher.sh: [[: not found
    [DEBUG] /bin/sh: 109: /opt/jdk_switcher/jdk_switcher.sh: Syntax error: "(" unexpected (expecting "fi")
    ```
    Googling it leads to https://github.com/travis-ci/travis-cookbooks/issues/964. I'd guess jdk_switcher isn't expecting to be called with a non-bash shell?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/srdo/storm STORM-2858-1.x

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/2496.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2496
    
----
commit 5753913436b72fb3f1844c25ea559d4bc02cff30
Author: Stig Rohde Døssing <sr...@...>
Date:   2017-12-13T15:47:31Z

    STORM-2858: Fix worker-launcher build by erroring out if asprintf fails to allocate memory. Replace make-maven-plugin with a build shell script.

----


---

[GitHub] storm pull request #2496: STORM-2858 1.x

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/storm/pull/2496


---