You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/02/20 10:16:42 UTC
[GitHub] [cloudstack] Spaceman1984 opened a new pull request #3901: Removed
unused vars from pom file
Spaceman1984 opened a new pull request #3901: Removed unused vars from pom file
URL: https://github.com/apache/cloudstack/pull/3901
## Description
<!--- Describe your changes in detail -->
Just some cleanup, these vars in the pom file are not being referenced from anywhere.
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [X] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
I ran a build after removing these vars and there were no issues.
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3901: Removed unused vars
from pom file
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3901: Removed unused vars from pom file
URL: https://github.com/apache/cloudstack/pull/3901#issuecomment-593810155
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3901: Removed unused
vars from pom file
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3901: Removed unused vars from pom file
URL: https://github.com/apache/cloudstack/pull/3901#issuecomment-593804377
Packaging result: ✖centos6 ✖centos7 ✖debian. JID-983
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3901: Removed unused
vars from pom file
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3901: Removed unused vars from pom file
URL: https://github.com/apache/cloudstack/pull/3901#issuecomment-593818341
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-987
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3901: Removed unused
vars from pom file
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3901: Removed unused vars from pom file
URL: https://github.com/apache/cloudstack/pull/3901#issuecomment-593810448
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3901: Removed unused vars
from pom file
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3901: Removed unused vars from pom file
URL: https://github.com/apache/cloudstack/pull/3901#issuecomment-593792111
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3901: Removed unused
vars from pom file
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3901: Removed unused vars from pom file
URL: https://github.com/apache/cloudstack/pull/3901#issuecomment-593819100
no runtime code changed, packaging works, two lgtm, merging
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland merged pull request #3901: Removed unused
vars from pom file
Posted by GitBox <gi...@apache.org>.
DaanHoogland merged pull request #3901: Removed unused vars from pom file
URL: https://github.com/apache/cloudstack/pull/3901
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] Spaceman1984 commented on issue #3901: Removed unused
vars from pom file
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on issue #3901: Removed unused vars from pom file
URL: https://github.com/apache/cloudstack/pull/3901#issuecomment-588952528
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3901: Removed unused
vars from pom file
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3901: Removed unused vars from pom file
URL: https://github.com/apache/cloudstack/pull/3901#issuecomment-593792238
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services