You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2017/02/23 20:04:46 UTC
Review Request 56994: "Set Version on All Hosts" Fails For Hosts
Without Any Stack Components
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56994/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
Bugs: AMBARI-20148
https://issues.apache.org/jira/browse/AMBARI-20148
Repository: ambari
Description
-------
During an upgrade, `hdp-select set all <version>` is sent to all hosts, even those which do not have any versionable components (metrics only, for example). This is done for two reason:
- Simplicity - we don't need to figure out which hosts to include
- Coverage - many clusters have clients not under our control, so invoking it on all hosts covers our bases
We need to ensure that if the stack-select tool doesn't exist or reports no versions, that we skip calling it.
Diffs
-----
ambari-server/src/main/resources/custom_actions/scripts/ru_set_all.py b7fcc51
ambari-server/src/test/python/custom_actions/test_ru_set_all.py b018605
Diff: https://reviews.apache.org/r/56994/diff/
Testing
-------
----------------------------------------------------------------------
Total run:1185
Total errors:0
Total failures:0
OK
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 58.155 s
[INFO] Finished at: 2017-02-23T14:49:03-05:00
[INFO] Final Memory: 18M/310M
[INFO] ------------------------------------------------------------------------
Thanks,
Jonathan Hurley
Re: Review Request 56994: "Set Version on All Hosts" Fails For Hosts
Without Any Stack Components
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56994/#review166678
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On Feb. 23, 2017, 10:04 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56994/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2017, 10:04 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
>
>
> Bugs: AMBARI-20148
> https://issues.apache.org/jira/browse/AMBARI-20148
>
>
> Repository: ambari
>
>
> Description
> -------
>
> During an upgrade, `hdp-select set all <version>` is sent to all hosts, even those which do not have any versionable components (metrics only, for example). This is done for two reason:
> - Simplicity - we don't need to figure out which hosts to include
> - Coverage - many clusters have clients not under our control, so invoking it on all hosts covers our bases
>
> We need to ensure that if the stack-select tool doesn't exist or reports no versions, that we skip calling it.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/custom_actions/scripts/ru_set_all.py b7fcc51
> ambari-server/src/test/python/custom_actions/test_ru_set_all.py b018605
>
> Diff: https://reviews.apache.org/r/56994/diff/
>
>
> Testing
> -------
>
> ----------------------------------------------------------------------
> Total run:1185
> Total errors:0
> Total failures:0
> OK
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 58.155 s
> [INFO] Finished at: 2017-02-23T14:49:03-05:00
> [INFO] Final Memory: 18M/310M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 56994: "Set Version on All Hosts" Fails For Hosts
Without Any Stack Components
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56994/#review166583
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Feb. 23, 2017, 8:04 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56994/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2017, 8:04 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
>
>
> Bugs: AMBARI-20148
> https://issues.apache.org/jira/browse/AMBARI-20148
>
>
> Repository: ambari
>
>
> Description
> -------
>
> During an upgrade, `hdp-select set all <version>` is sent to all hosts, even those which do not have any versionable components (metrics only, for example). This is done for two reason:
> - Simplicity - we don't need to figure out which hosts to include
> - Coverage - many clusters have clients not under our control, so invoking it on all hosts covers our bases
>
> We need to ensure that if the stack-select tool doesn't exist or reports no versions, that we skip calling it.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/custom_actions/scripts/ru_set_all.py b7fcc51
> ambari-server/src/test/python/custom_actions/test_ru_set_all.py b018605
>
> Diff: https://reviews.apache.org/r/56994/diff/
>
>
> Testing
> -------
>
> ----------------------------------------------------------------------
> Total run:1185
> Total errors:0
> Total failures:0
> OK
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 58.155 s
> [INFO] Finished at: 2017-02-23T14:49:03-05:00
> [INFO] Final Memory: 18M/310M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 56994: "Set Version on All Hosts" Fails For Hosts
Without Any Stack Components
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56994/#review166580
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On Feb. 23, 2017, 3:04 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56994/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2017, 3:04 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
>
>
> Bugs: AMBARI-20148
> https://issues.apache.org/jira/browse/AMBARI-20148
>
>
> Repository: ambari
>
>
> Description
> -------
>
> During an upgrade, `hdp-select set all <version>` is sent to all hosts, even those which do not have any versionable components (metrics only, for example). This is done for two reason:
> - Simplicity - we don't need to figure out which hosts to include
> - Coverage - many clusters have clients not under our control, so invoking it on all hosts covers our bases
>
> We need to ensure that if the stack-select tool doesn't exist or reports no versions, that we skip calling it.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/custom_actions/scripts/ru_set_all.py b7fcc51
> ambari-server/src/test/python/custom_actions/test_ru_set_all.py b018605
>
> Diff: https://reviews.apache.org/r/56994/diff/
>
>
> Testing
> -------
>
> ----------------------------------------------------------------------
> Total run:1185
> Total errors:0
> Total failures:0
> OK
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 58.155 s
> [INFO] Finished at: 2017-02-23T14:49:03-05:00
> [INFO] Final Memory: 18M/310M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Jonathan Hurley
>
>