[GitHub] [netbeans] mbien commented on a diff in pull request #4306: Git: replace invalid characters in branch name

[GitBox <gi...@apache.org>]

mbien commented on code in PR #4306:
URL: https://github.com/apache/netbeans/pull/4306#discussion_r911501380


##########
ide/git/src/org/netbeans/modules/git/ui/branch/CreateBranch.java:
##########
@@ -146,7 +150,7 @@ private void validateName () {
         if (branchName.isEmpty()) {
             msgInvalidName = Bundle.MSG_CreateBranch_errorBranchNameEmpty();
         } else if (!GitUtils.isValidBranchName(branchName)) {
-            msgInvalidName = Bundle.MSG_CreateBranch_errorInvalidBranchName();
+                msgInvalidName = Bundle.MSG_CreateBranch_errorInvalidBranchName();

Review Comment:
   same here



##########
ide/git/src/org/netbeans/modules/git/ui/branch/CreateBranch.java:
##########
@@ -111,8 +115,8 @@ private void validate () {
             setErrorMessage(msgInvalidName);
         }
         if (flag) {
-            setErrorMessage(null);
-        }
+                setErrorMessage(null);
+            }

Review Comment:
   what happened here? ;)



##########
ide/git/src/org/netbeans/modules/git/options/GitOptionsPanel.java:
##########
@@ -149,7 +157,7 @@ private void initComponents() {
                     .addComponent(jLabel2)
                     .addComponent(txtProjectAnnotation, javax.swing.GroupLayout.PREFERRED_SIZE, javax.swing.GroupLayout.DEFAULT_SIZE, javax.swing.GroupLayout.PREFERRED_SIZE)
                     .addComponent(btnAddVariable))
-                .addContainerGap(javax.swing.GroupLayout.DEFAULT_SIZE, Short.MAX_VALUE))
+                .addContainerGap(10, Short.MAX_VALUE))

Review Comment:
   could you go though all check boxes in this panel and do the following:
    - right click -> Edit Layout Space...
    - make sure Top and Bottom is set to "default medium"
   
   so that we don't have fixed gaps defined, this would look inconsistent if if some UI settings change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists