You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2019/09/19 17:31:00 UTC
[jira] [Commented] (IMPALA-8761) Configuration validation
introduced in IMPALA-8559 can be improved
[ https://issues.apache.org/jira/browse/IMPALA-8761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16933612#comment-16933612 ]
ASF subversion and git services commented on IMPALA-8761:
---------------------------------------------------------
Commit b2e5e942867ee1eeca754fd383075e7db3c8b590 in impala's branch refs/heads/master from Anurag Mantripragada
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=b2e5e94 ]
IMPALA-8761: Improve events processor configuration validation.
This patch aims to improve the validation of configuration keys
from the HMS.
IMPALA-8559 introduced configuration validation for events processor
configurations. In the existing implementation, the events processor
errors out as soon as it sees a validation failure. If there are
more than one configuration errors, the users may have to restart
HMS each time they fix a configuration error. This is bad user
experience. This change collects all the configuration issues and
logs expected values before erroring out. Users can now fix all
issues in one go.
Testing:
Added testValidateConfigs() to assert if multiple incorrect values
are detected at once.
Change-Id: I73480872ef93215d05c1fd922e64eb68a8a63a42
Reviewed-on: http://gerrit.cloudera.org:8080/14240
Reviewed-by: Bharath Vissapragada <bh...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
> Configuration validation introduced in IMPALA-8559 can be improved
> ------------------------------------------------------------------
>
> Key: IMPALA-8761
> URL: https://issues.apache.org/jira/browse/IMPALA-8761
> Project: IMPALA
> Issue Type: Sub-task
> Reporter: Vihang Karajgaonkar
> Assignee: Anurag Mantripragada
> Priority: Major
>
> The issue with configuration validation in IMPALA-8559 is that it validates one configuration at a time and fails as soon as there is a validation error. Since there are more than one configuration keys to validate, user may have to restart HMS again and again if there are multiple configuration changes which are needed. This is not a great user experience. A simple improvement that can be made is do all the configuration validations together and then present the results together in case of failures so that user can change all the required changes in one go.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org