You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2022/09/23 07:47:49 UTC

[GitHub] [servicecomb-java-chassis] liubao68 opened a new pull request, #3358: [SCB-2424]RpcReference support setter injection

liubao68 opened a new pull request, #3358:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3358

   Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
    - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] Run `mvn clean install -Pit` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] liubao68 merged pull request #3358: [SCB-2424]RpcReference support setter injection

Posted by GitBox <gi...@apache.org>.
liubao68 merged PR #3358:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3358


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] codecov-commenter commented on pull request #3358: [SCB-2424]RpcReference support setter injection

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #3358:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3358#issuecomment-1255920379

   # [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3358?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#3358](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3358?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b7dccdb) into [master](https://codecov.io/gh/apache/servicecomb-java-chassis/commit/f8366f381152866464f8826ad35ad95d7d079a93?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f8366f3) will **increase** coverage by `0.01%`.
   > The diff coverage is `92.30%`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #3358      +/-   ##
   ============================================
   + Coverage     77.55%   77.57%   +0.01%     
   - Complexity     1458     1462       +4     
   ============================================
     Files          1649     1650       +1     
     Lines         43750    43772      +22     
     Branches       3684     3685       +1     
   ============================================
   + Hits          33931    33955      +24     
     Misses         8280     8280              
   + Partials       1539     1537       -2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3358?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...provider/pojo/reference/RpcReferenceProcessor.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3358/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdmlkZXJzL3Byb3ZpZGVyLXBvam8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL3Byb3ZpZGVyL3Bvam8vcmVmZXJlbmNlL1JwY1JlZmVyZW5jZVByb2Nlc3Nvci5qYXZh) | `94.28% <88.88%> (-5.72%)` | :arrow_down: |
   | [...o/pojo/client/TestRpcReferenceMethodInjection.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3358/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGVtby9kZW1vLXBvam8vcG9qby1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2RlbW8vcG9qby9jbGllbnQvVGVzdFJwY1JlZmVyZW5jZU1ldGhvZEluamVjdGlvbi5qYXZh) | `100.00% <100.00%> (ø)` | |
   | [.../servicecomb/registry/discovery/DiscoveryTree.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3358/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1yZWdpc3RyeS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvcmVnaXN0cnkvZGlzY292ZXJ5L0Rpc2NvdmVyeVRyZWUuamF2YQ==) | `100.00% <0.00%> (+3.50%)` | :arrow_up: |
   | [...mb/metrics/core/meter/os/cpu/AbstractCpuUsage.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3358/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWV0cmljcy9tZXRyaWNzLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL21ldHJpY3MvY29yZS9tZXRlci9vcy9jcHUvQWJzdHJhY3RDcHVVc2FnZS5qYXZh) | `100.00% <0.00%> (+11.11%)` | :arrow_up: |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org