You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by max3163 <gi...@git.apache.org> on 2016/12/14 17:49:25 UTC

[GitHub] jmeter pull request #240: Improves JMS component robustness

GitHub user max3163 opened a pull request:

    https://github.com/apache/jmeter/pull/240

    Improves JMS component robustness

    For both publisher and subcriber : improve error handling and allow to force reconnection against some error codes (using a new UI field and regular expression)
    
    Only for subscriber, adds a wait between errors to avoid UI freeze due to infinite loops in case of repetitive errors.
    
    PS : Some code relies on Java 8 (Predicate & lambda)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/max3163/jmeter POW-314

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/jmeter/pull/240.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #240
    
----
commit 36dd9f7ec959c69e06b7bf52f2ddb5866d822797
Author: Bruno Demion <mi...@apache.org>
Date:   2016-11-16T18:45:11Z

    Tag for pre-release
    
    git-svn-id: https://svn.apache.org/repos/asf/jmeter/tags/v3_1_RC4@1770033 13f79535-47bb-0310-9956-ffa450edef68

commit 0b5b61f85c494dedd43ac1648bec96c92a6af33e
Author: Bruno Demion <mi...@apache.org>
Date:   2016-11-19T22:49:23Z

    Vote succeeded, create the 3.1 tag
    
    git-svn-id: https://svn.apache.org/repos/asf/jmeter/tags/v3_1@1770529 13f79535-47bb-0310-9956-ffa450edef68

commit a252284ac3dc806f7d0d327fa441b16d551cfb5f
Author: Logan Mauzaize & Maxime Chassagneux <ma...@users.noreply.github.com>
Date:   2016-12-14T17:42:05Z

    POW-314 Improves JMS component robustness

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter issue #240: Improves JMS component robustness

Posted by loganmzz <gi...@git.apache.org>.
Github user loganmzz commented on the issue:

    https://github.com/apache/jmeter/pull/240
  
    Here is a sample script to check robustness against an ActiveMQ instance.
    
    [JMeter-ActiveMQ.zip](https://github.com/apache/jmeter/files/661260/JMeter-ActiveMQ.zip)
    
    Try to launch script with a started/stopped server, and stop/restart server to check samples and JMeter behaviour.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter pull request #240: Improves JMS component robustness

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/jmeter/pull/240


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter issue #240: Improves JMS component robustness

Posted by loganmzz <gi...@git.apache.org>.
Github user loganmzz commented on the issue:

    https://github.com/apache/jmeter/pull/240
  
    Close publisher isn't supposed to throw exception. A quick view at the code, confirms only system (in VM sense) error can be raised. What is supposed to be done in this case ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter issue #240: Improves JMS component robustness

Posted by pmouawad <gi...@git.apache.org>.
Github user pmouawad commented on the issue:

    https://github.com/apache/jmeter/pull/240
  
    Thanks for contribution.
    Few notes:
    
    -  docs (component-reference.xml) should  be updated 
    - In handleError, I think you should surround close line 232 with try/catch
    
    
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter issue #240: Improves JMS component robustness

Posted by pmouawad <gi...@git.apache.org>.
Github user pmouawad commented on the issue:

    https://github.com/apache/jmeter/pull/240
  
    Hello,
    Thanks for PR.
    I have commited it but with some slight changes.
    Could you test nightly build and give us feedback ?
    Also could you attach the JMX plan that you attached to this PR as a zip (which I am not able to read) to the bugzilla 60585
    
    Thank you


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---